Re: [PATCH v5 next 2/7] iio: sca3000: switch IRQ handling to devm helpers

Andy Shevchenko
2026-02-05T16:45:34Z

On Thu, Feb 05, 2026 at 10:09:45PM +0530, Harshit Mogalapalli wrote:
> On 05/02/26 21:53, Andy Shevchenko wrote:
> > On Thu, Feb 05, 2026 at 05:12:08AM -0800, Harshit Mogalapalli wrote:

...

> > > - if (spi->irq)
> > > - free_irq(spi->irq, indio_dev);
> >
> > Do we need an irq member to be in the struct after this patch?
>
> I probably didn't understand that question fully.
>
> we still have a call to ret = devm_request_threaded_irq(dev, spi->irq,
> NULL,...) so we can't relaly get rid of the irq member I think,
> did I understand your question right ?

Yes. But now I realised that this is the external structure, and not the one
the driver defines. Sorry for the noise.

--
With Best Regards,
Andy Shevchenko