Re: [PATCH v5 next 7/7] iio: sca3000: manage device registration with devm helper

Harshit Mogalapalli
2026-02-05T16:51:53Z

Hi Andy,

On 05/02/26 21:59, Andy Shevchenko wrote:
> On Thu, Feb 05, 2026 at 05:12:13AM -0800, Harshit Mogalapalli wrote:
>> Convert the iio registration to use devm_* helpers so the probe no
>> longer needs a separate cleanup path and remove callback can also drop
>> the unregister. After this there is no need for having a remove
>> callback, so remote it.
>>
>> No functional change intended.
>
> ...
>
>> - struct iio_dev *indio_dev = spi_get_drvdata(spi);
>
> Do you still need spi_set_drvdata() or analogue in the ->probe()?
>

That's a great catch, I don't see spi_get_drvdata() anymore after this
series, so yes I think we should get rid of this.

Should I fold that into this patch in v6, as spi_get_drvdata() is also
removed in this patch ?

Thanks,
Harshit