Re: [PATCH v5 next 2/7] iio: sca3000: switch IRQ handling to devm helpers

Andy Shevchenko
2026-02-05T16:23:25Z

On Thu, Feb 05, 2026 at 05:12:08AM -0800, Harshit Mogalapalli wrote:
> Convert the threaded IRQ registration to devm_request_threaded_irq() so
> that the probe and remove paths can drop manual freeing of irqs.
>
> No functionality change.

...

> -error_free_irq:
> - if (spi->irq)
> - free_irq(spi->irq, indio_dev);
> -
> - return ret;

...

> - if (spi->irq)
> - free_irq(spi->irq, indio_dev);

Do we need an irq member to be in the struct after this patch?

--
With Best Regards,
Andy Shevchenko