From: Romain Perier <romain.perier@free-electrons.com>
To: Dan Carpenter
<dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch 2/3] spi: armada-3700: Set mode bits correctly
Date: Fri, 16 Dec 2016 10:30:01 +0000 [thread overview]
Message-ID: <aacbdfad-e29f-9af0-215c-93ee026db570@free-electrons.com> (raw)
In-Reply-To: <20161216093325.GA13942-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
Hello,
Le 16/12/2016 à 10:33, Dan Carpenter a écrit :
> We set SPI_RX_DUAL twice instead of setting SPI_TX_DUAL.
>
> Fixes: 5762ab71eb24 ("spi: Add support for Armada 3700 SPI Controller")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/spi/spi-armada-3700.c b/drivers/spi/spi-armada-3700.c
> index 5c7508dc6f0b..40491be3365f 100644
> --- a/drivers/spi/spi-armada-3700.c
> +++ b/drivers/spi/spi-armada-3700.c
> @@ -825,7 +825,7 @@ static int a3700_spi_probe(struct platform_device *pdev)
> master->unprepare_message = a3700_spi_unprepare_message;
> master->set_cs = a3700_spi_set_cs;
> master->flags = SPI_MASTER_HALF_DUPLEX;
> - master->mode_bits |= (SPI_RX_DUAL | SPI_RX_DUAL |
> + master->mode_bits |= (SPI_RX_DUAL | SPI_TX_DUAL |
> SPI_RX_QUAD | SPI_TX_QUAD);
>
> platform_set_drvdata(pdev, master);
>
Good catch,
Acked-by: Romain Perier <romain.perier@free-electrons.com>
Thanks,
Romain
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-12-16 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 9:33 [patch 2/3] spi: armada-3700: Set mode bits correctly Dan Carpenter
[not found] ` <20161216093325.GA13942-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2016-12-16 10:30 ` Romain Perier [this message]
2016-12-16 12:31 ` Applied "spi: armada-3700: Set mode bits correctly" to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aacbdfad-e29f-9af0-215c-93ee026db570@free-electrons.com \
--to=romain.perier@free-electrons.com \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox