Re: exfat: Fix 2 issues found by static code analysis

Re: exfat: Fix 2 issues found by static code analysis

[Markus Elfring]

By the way:
It can be helpful to number prefixes according to message subjects in patch series.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc2#n711


> I'm going through our list of issues found by static code analysis using Klocwork.

Does this tool point any more implementation details out for further development considerations
(with other software components)?

Regards,
Markus

Re: exfat: Fix 2 issues found by static code analysis

[Philipp Hahn]

Hello Markus,

Am Wed, Mar 04, 2026 at 09:40:37AM +0100 schrieb Markus Elfring:
> By the way:
> It can be helpful to number prefixes according to message subjects in patch series.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.0-rc2#n711

Yes, thank you for the reminder.

> > I'm going through our list of issues found by static code analysis using Klocwork.
> 
> Does this tool point any more implementation details out for further development considerations
> (with other software components)?

This was a run on our internal version of exfat, which matches
'github.com/namjaejeon/linux-exfat-oot/for-kernel-version-from-4.1.0'.

Klocwork found no other issues worth fixing in that version.

If my time permits I will run it again on latest 'linux-7.0-rc`
respective 'master' to see if anything "new" crept in.

I'll also report any other findings outside of exfat when I find them.

Philipp

Re: exfat: Fix 2 issues found by static code analysis

[Markus Elfring]

>>> I'm going through our list of issues found by static code analysis using Klocwork.
>>
>> Does this tool point any more implementation details out for further development considerations
>> (with other software components)?
> 
> This was a run on our internal version of exfat, which matches
> 'github.com/namjaejeon/linux-exfat-oot/for-kernel-version-from-4.1.0'.

Thanks for such background information.


> If my time permits I will run it again on latest 'linux-7.0-rc`
> respective 'master' to see if anything "new" crept in.

It is probably nicer to repeat source code analyses on more recent
software revisions occasionally.


> I'll also report any other findings outside of exfat when I find them.

I became curious on the aspect on how many development resources
you may invest then.

Regards,
Markus