From: Dan Carpenter <error27@gmail.com>
To: Adrian McMenamin <adrianmcmenamin@gmail.com>
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Ensure Dreamcast VMU code keeps building
Date: Mon, 30 Mar 2026 12:35:59 +0300 [thread overview]
Message-ID: <acbc0m-O97qdc6Z6@stanley.mountain> (raw)
In-Reply-To: <CACwZE5SJiHmoufCMAP5pJtRn=LRN9Jp3=zSh2j0UoUikwVKr-g@mail.gmail.com>
git log --oneline drivers/mtd/maps/vmu-flash.c | head
The subsystem prefix for this file is "mtd: maps: vmu-flash:".
I wouldn't normally nit-pick, but you're going to need to resend this
anyay. A better subject would be:
[PATCH] mtd: maps: vmu-flash: include device.h explicitly
On Fri, Mar 27, 2026 at 06:12:30PM +0000, Adrian McMenamin wrote:
> Make necessary include explicit
Add a period on the end of the sentence.
Why is the include necessary? There isn't enough context in the
diff to see and I don't want to spend time figuring it out myself.
When you resend, send it to the people from:
./scripts/get_maintainer.pl -f drivers/mtd/maps/vmu-flash.c
regards,
dan carpenter
prev parent reply other threads:[~2026-03-30 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 18:12 [PATCH] Ensure Dreamcast VMU code keeps building Adrian McMenamin
2026-03-30 9:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acbc0m-O97qdc6Z6@stanley.mountain \
--to=error27@gmail.com \
--cc=adrianmcmenamin@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox