public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Ensure Dreamcast VMU code keeps building
@ 2026-03-27 18:12 Adrian McMenamin
  2026-03-30  9:35 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian McMenamin @ 2026-03-27 18:12 UTC (permalink / raw)
  To: kernel-janitors

Make necessary include explicit

Signed-off-by: Adrian McMenamin <adrianmcmenamin@gmail.com>
---
drivers/mtd/maos/vmu-flash.c | 1+
1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c
index 75e06d249ce9..7c18658a5e7d 100644
--- a/drivers/mtd/maps/vmu-flash.c
+++ b/drivers/mtd/maps/vmu-flash.c
@@ -6,6 +6,7 @@
  * Copyright (c) Paul Mundt 2001
  */
 #include <linux/init.h>
+#include <linux/device.h>
 #include <linux/slab.h>
 #include <linux/sched.h>
 #include <linux/delay.h>
--

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Ensure Dreamcast VMU code keeps building
  2026-03-27 18:12 [PATCH] Ensure Dreamcast VMU code keeps building Adrian McMenamin
@ 2026-03-30  9:35 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-03-30  9:35 UTC (permalink / raw)
  To: Adrian McMenamin; +Cc: kernel-janitors

git log --oneline drivers/mtd/maps/vmu-flash.c  | head

The subsystem prefix for this file is "mtd: maps: vmu-flash:".

I wouldn't normally nit-pick, but you're going to need to resend this
anyay.  A better subject would be:

[PATCH] mtd: maps: vmu-flash: include device.h explicitly

On Fri, Mar 27, 2026 at 06:12:30PM +0000, Adrian McMenamin wrote:
> Make necessary include explicit

Add a period on the end of the sentence.

Why is the include necessary?  There isn't enough context in the
diff to see and I don't want to spend time figuring it out myself.

When you resend, send it to the people from:
./scripts/get_maintainer.pl -f drivers/mtd/maps/vmu-flash.c

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-03-30  9:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-27 18:12 [PATCH] Ensure Dreamcast VMU code keeps building Adrian McMenamin
2026-03-30  9:35 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox