From: Dan Carpenter <error27@gmail.com>
To: Adrian McMenamin <adrianmcmenamin@gmail.com>
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Update email addresses and firmware URL for Dreamcast drivers
Date: Mon, 30 Mar 2026 12:35:17 +0300 [thread overview]
Message-ID: <acoiS9jv3VmAjSXK@stanley.mountain> (raw)
In-Reply-To: <CACwZE5SoPg6oAgt6ok1vMfrZdCfwLTztoWbrLAnZ1y1BZOzkew@mail.gmail.com>
Hi Adrian,
Kernel janitors doesn't really merge any code. You need to send it to
the relevant lists from the scripts/get_maintainer.pl script.
On Sat, Mar 28, 2026 at 07:09:05PM +0000, Adrian McMenamin wrote:
> None of what follows alters compiled code, it merely updates contact
> details and the address for sound firmware. Hopefully this is the
> correct list for this. If not, please let me know
>
>
> Use current email and firmware address for various Dreamcast drivers
>
>
>
* The subject needs to have a subsystem prefix
* The commit message needs to say something like:
"Update contact details and the address for sound firmware for
for various Dreamcast drivers."
The other meta information is unnecessary or you could put it under
the --- cut off line below the Signed-off-by line.
* You need to have a Signed-off-by line.
> diff --git a/sound/sh/aica.c b/sound/sh/aica.c
> index 9438c3a68ee9..ed262e2263d1 100644
> --- a/sound/sh/aica.c
> +++ b/sound/sh/aica.c
> @@ -2,10 +2,10 @@
> /*
> *
> * Copyright Adrian McMenamin 2005, 2006, 2007
> -* <adrian@mcmen.demon.co.uk>
> +* <adrianmcmenamin@gmail.com>
> * Requires firmware (BSD licenced) available from:
> -* http://linuxdc.cvs.sourceforge.net/linuxdc/linux-sh-dc/sound/oss/aica/firmware/
> -* or the maintainer
> +* https://www.alsa-project.org/files/pub/firmware/
> +* (aica_firmware.bin)
> */
>
I don't know the ALSA devs will care either way but I would probably
put this change in a separate patch from the email changes.
regards,
dan carpenter
prev parent reply other threads:[~2026-03-30 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 19:09 [PATCH] Update email addresses and firmware URL for Dreamcast drivers Adrian McMenamin
2026-03-30 9:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acoiS9jv3VmAjSXK@stanley.mountain \
--to=error27@gmail.com \
--cc=adrianmcmenamin@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox