* Re: [PATCH] infiniband: adding __init/__exit macros to addr.c and
2009-06-11 0:00 [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Peter Hüwe
@ 2009-06-12 9:02 ` Jiri Kosina
2009-06-16 15:49 ` [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Sean Hefty
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Jiri Kosina @ 2009-06-12 9:02 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1779 bytes --]
[ CCing Infiniband maintainers in case they prefer taking it through the
subsystem tree ]
On Thu, 11 Jun 2009, Peter Hüwe wrote:
> From: Peter Huewe <peterhuewe@gmx.de>
>
> Trivial patch which adds the __init and __exit macros to the module_init /
> module_exit functions from drivers/infiniband/core/addr.c and cma.c
> linux version 2.6.30
>
> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
> ---
> diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
> index ce511d8..5be1bd4 100644
> --- a/drivers/infiniband/core/addr.c
> +++ b/drivers/infiniband/core/addr.c
> @@ -514,7 +514,7 @@ static struct notifier_block nb = {
> .notifier_call = netevent_callback
> };
>
> -static int addr_init(void)
> +static int __init addr_init(void)
> {
> addr_wq = create_singlethread_workqueue("ib_addr");
> if (!addr_wq)
> @@ -524,7 +524,7 @@ static int addr_init(void)
> return 0;
> }
>
> -static void addr_cleanup(void)
> +static void __exit addr_cleanup(void)
> {
> unregister_netevent_notifier(&nb);
> destroy_workqueue(addr_wq);
> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
> index 851de83..0753178 100644
> --- a/drivers/infiniband/core/cma.c
> +++ b/drivers/infiniband/core/cma.c
> @@ -2960,7 +2960,7 @@ static void cma_remove_one(struct ib_device *device)
> kfree(cma_dev);
> }
>
> -static int cma_init(void)
> +static int __init cma_init(void)
> {
> int ret, low, high, remaining;
>
> @@ -2990,7 +2990,7 @@ err:
> return ret;
> }
>
> -static void cma_cleanup(void)
> +static void __exit cma_cleanup(void)
> {
> ib_unregister_client(&cma_client);
> unregister_netdevice_notifier(&cma_nb);
>
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 7+ messages in thread* RE: [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c
2009-06-11 0:00 [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Peter Hüwe
2009-06-12 9:02 ` [PATCH] infiniband: adding __init/__exit macros to addr.c and Jiri Kosina
@ 2009-06-16 15:49 ` Sean Hefty
2009-06-22 21:50 ` Peter Huewe
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Sean Hefty @ 2009-06-16 15:49 UTC (permalink / raw)
To: kernel-janitors
>> From: Peter Huewe <peterhuewe@gmx.de>
>>
>> Trivial patch which adds the __init and __exit macros to the module_init /
>> module_exit functions from drivers/infiniband/core/addr.c and cma.c
>> linux version 2.6.30
>>
>> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Sean Hefty <sean.hefty@intel.com>
Roland, did you want to pull this through your tree?
>> ---
>> diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
>> index ce511d8..5be1bd4 100644
>> --- a/drivers/infiniband/core/addr.c
>> +++ b/drivers/infiniband/core/addr.c
>> @@ -514,7 +514,7 @@ static struct notifier_block nb = {
>> .notifier_call = netevent_callback
>> };
>>
>> -static int addr_init(void)
>> +static int __init addr_init(void)
>> {
>> addr_wq = create_singlethread_workqueue("ib_addr");
>> if (!addr_wq)
>> @@ -524,7 +524,7 @@ static int addr_init(void)
>> return 0;
>> }
>>
>> -static void addr_cleanup(void)
>> +static void __exit addr_cleanup(void)
>> {
>> unregister_netevent_notifier(&nb);
>> destroy_workqueue(addr_wq);
>> diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
>> index 851de83..0753178 100644
>> --- a/drivers/infiniband/core/cma.c
>> +++ b/drivers/infiniband/core/cma.c
>> @@ -2960,7 +2960,7 @@ static void cma_remove_one(struct ib_device *device)
>> kfree(cma_dev);
>> }
>>
>> -static int cma_init(void)
>> +static int __init cma_init(void)
>> {
>> int ret, low, high, remaining;
>>
>> @@ -2990,7 +2990,7 @@ err:
>> return ret;
>> }
>>
>> -static void cma_cleanup(void)
>> +static void __exit cma_cleanup(void)
>> {
>> ib_unregister_client(&cma_client);
>> unregister_netdevice_notifier(&cma_nb);
>>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c
2009-06-11 0:00 [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Peter Hüwe
2009-06-12 9:02 ` [PATCH] infiniband: adding __init/__exit macros to addr.c and Jiri Kosina
2009-06-16 15:49 ` [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Sean Hefty
@ 2009-06-22 21:50 ` Peter Huewe
2009-06-23 0:21 ` Roland Dreier
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Peter Huewe @ 2009-06-22 21:50 UTC (permalink / raw)
To: kernel-janitors
Am Dienstag 16 Juni 2009 17:49:38 schrieb Sean Hefty:
> >> From: Peter Huewe <peterhuewe@gmx.de>
> >>
> >> Trivial patch which adds the __init and __exit macros to the module_init
> >> / module_exit functions from drivers/infiniband/core/addr.c and cma.c
> >> linux version 2.6.30
> >>
> >> Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
>
> Acked-by: Sean Hefty <sean.hefty@intel.com>
>
> Roland, did you want to pull this through your tree?
>
Hi,
may I ask what is the status of the patch?
Is it currently in any of your trees?
bye,
Peter
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c
2009-06-11 0:00 [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Peter Hüwe
` (2 preceding siblings ...)
2009-06-22 21:50 ` Peter Huewe
@ 2009-06-23 0:21 ` Roland Dreier
2009-06-23 0:41 ` Peter Huewe
2009-06-23 5:25 ` Roland Dreier
5 siblings, 0 replies; 7+ messages in thread
From: Roland Dreier @ 2009-06-23 0:21 UTC (permalink / raw)
To: kernel-janitors
I didn't see the original patch go by, but it's fine to go in through
the trivial tree too. Otherwise please resend me the original patch and
I'll queue it up.
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c
2009-06-11 0:00 [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Peter Hüwe
` (3 preceding siblings ...)
2009-06-23 0:21 ` Roland Dreier
@ 2009-06-23 0:41 ` Peter Huewe
2009-06-23 5:25 ` Roland Dreier
5 siblings, 0 replies; 7+ messages in thread
From: Peter Huewe @ 2009-06-23 0:41 UTC (permalink / raw)
To: kernel-janitors
From: Peter Huewe <peterhuewe@gmx.de>
Trivial patch which adds the __init and __exit macros to the module_init /
module_exit functions from drivers/infiniband/core/addr.c and cma.c
linux version 2.6.30
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Sean Hefty <sean.hefty@intel.com>
---
Hi Roland,
here is the patch :) - it's really trivial I know.
I think it's faster to pull it through your tree, jini has a lot to do I
guess.
Thanks, Peter
diff --git a/drivers/infiniband/core/addr.c b/drivers/infiniband/core/addr.c
index ce511d8..5be1bd4 100644
--- a/drivers/infiniband/core/addr.c
+++ b/drivers/infiniband/core/addr.c
@@ -514,7 +514,7 @@ static struct notifier_block nb = {
.notifier_call = netevent_callback
};
-static int addr_init(void)
+static int __init addr_init(void)
{
addr_wq = create_singlethread_workqueue("ib_addr");
if (!addr_wq)
@@ -524,7 +524,7 @@ static int addr_init(void)
return 0;
}
-static void addr_cleanup(void)
+static void __exit addr_cleanup(void)
{
unregister_netevent_notifier(&nb);
destroy_workqueue(addr_wq);
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 851de83..0753178 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -2960,7 +2960,7 @@ static void cma_remove_one(struct ib_device *device)
kfree(cma_dev);
}
-static int cma_init(void)
+static int __init cma_init(void)
{
int ret, low, high, remaining;
@@ -2990,7 +2990,7 @@ err:
return ret;
}
-static void cma_cleanup(void)
+static void __exit cma_cleanup(void)
{
ib_unregister_client(&cma_client);
unregister_netdevice_notifier(&cma_nb);
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c
2009-06-11 0:00 [PATCH] infiniband: adding __init/__exit macros to addr.c and cma.c Peter Hüwe
` (4 preceding siblings ...)
2009-06-23 0:41 ` Peter Huewe
@ 2009-06-23 5:25 ` Roland Dreier
5 siblings, 0 replies; 7+ messages in thread
From: Roland Dreier @ 2009-06-23 5:25 UTC (permalink / raw)
To: kernel-janitors
OK, thanks, applied.
^ permalink raw reply [flat|nested] 7+ messages in thread