From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Date: Thu, 05 Aug 2010 20:31:24 +0000 Subject: Re: [PATCH 4/42] drivers/infiniband/hw/nes: Adjust confusing if indentation Message-Id: List-Id: References: In-Reply-To: (Julia Lawall's message of "Thu, 5 Aug 2010 22:18:01 +0200 (CEST)") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: Faisal Latif , Chien Tung , Roland Dreier , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org > It is not clear whether the assignment should be part of the if branch > suggested by its indentation. The patch preserves the current semantics. Thanks. Chien/Faisal -- are the current semantics correct or should we add braces { } to match the indentation? From a quick look at the code, I think the patch we actually want is: drivers/infiniband/hw/nes/nes_hw.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_hw.c b/drivers/infiniband/hw/nes/nes_hw.c index 07c4004..f8233c8 100644 --- a/drivers/infiniband/hw/nes/nes_hw.c +++ b/drivers/infiniband/hw/nes/nes_hw.c @@ -2737,9 +2737,9 @@ void nes_nic_ce_handler(struct nes_device *nesdev, struct nes_hw_nic_cq *cq) nesnic->sq_tail &= nesnic->sq_size-1; if (sq_cqes > 128) { barrier(); - /* restart the queue if it had been stopped */ - if (netif_queue_stopped(nesvnic->netdev)) - netif_wake_queue(nesvnic->netdev); + /* restart the queue if it had been stopped */ + if (netif_queue_stopped(nesvnic->netdev)) + netif_wake_queue(nesvnic->netdev); sq_cqes = 0; } } else { -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html