* [PATCH 4/5] drivers/infiniband: remove duplicate structure field
@ 2009-09-19 19:49 Julia Lawall
[not found] ` <Pine.LNX.4.64.0909192149040.27171-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2009-09-19 19:49 UTC (permalink / raw)
To: hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, Sean Hefty, Roland Dreier,
Chien Tung, Faisal Latif, linux-rd
From: Julia Lawall <julia@diku.dk>
The definition of nes_netdev_ops has initializations of a local function
and eth_mac_addr for its ndo_set_mac_address field. This change uses only
the local function.
The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@
struct I s =@p0 { ... .fld@p = E, ...};
@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@
struct I s =@p0 { ... .fld@p = E, ...};
@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@
if int(ps[0].line)!=int(pr[0].line) or int(ps[0].column)!=int(pr[0].column):
cocci.print_main(fld,p0)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/infiniband/hw/nes/nes_nic.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/nes/nes_nic.c b/drivers/infiniband/hw/nes/nes_nic.c
index 538e409..e593af3 100644
--- a/drivers/infiniband/hw/nes/nes_nic.c
+++ b/drivers/infiniband/hw/nes/nes_nic.c
@@ -1566,7 +1566,6 @@ static const struct net_device_ops nes_netdev_ops = {
.ndo_set_mac_address = nes_netdev_set_mac_address,
.ndo_set_multicast_list = nes_netdev_set_multicast_list,
.ndo_change_mtu = nes_netdev_change_mtu,
- .ndo_set_mac_address = eth_mac_addr,
.ndo_validate_addr = eth_validate_addr,
.ndo_vlan_rx_register = nes_netdev_vlan_rx_register,
};
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/5] drivers/infiniband: remove duplicate structure field initialization
[not found] ` <Pine.LNX.4.64.0909192149040.27171-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
@ 2009-09-24 17:59 ` Roland Dreier
0 siblings, 0 replies; 2+ messages in thread
From: Roland Dreier @ 2009-09-24 17:59 UTC (permalink / raw)
To: Julia Lawall
Cc: hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w, Sean Hefty, Roland Dreier,
Chien Tung, Faisal Latif, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
thanks, applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-09-24 17:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-19 19:49 [PATCH 4/5] drivers/infiniband: remove duplicate structure field Julia Lawall
[not found] ` <Pine.LNX.4.64.0909192149040.27171-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
2009-09-24 17:59 ` [PATCH 4/5] drivers/infiniband: remove duplicate structure field initialization Roland Dreier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).