public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Josua Mayer <josua@solid-run.com>
Cc: kernel-janitors@vger.kernel.org
Subject: [bug report] mux: Add helper functions for getting optional and selected mux-state
Date: Fri, 10 Apr 2026 13:12:34 +0300	[thread overview]
Message-ID: <adjNEl0C8OgEjMI7@stanley.mountain> (raw)

Hello Josua Mayer,

Commit 993bcaf32c49 ("mux: Add helper functions for getting optional
and selected mux-state") from Feb 26, 2026 (linux-next), leads to the
following Smatch static checker warning:

	drivers/mux/core.c:640 mux_control_get()
	warn: 'mux' is an error pointer or valid

drivers/mux/core.c
    630  * mux_control_get() - Get the mux-control for a device.
    631  * @dev: The device that needs a mux-control.
    632  * @mux_name: The name identifying the mux-control.
    633  *
    634  * Return: A pointer to the mux-control, or an ERR_PTR with a negative errno.
    635  */
    636 struct mux_control *mux_control_get(struct device *dev, const char *mux_name)
    637 {
    638         struct mux_control *mux = mux_get(dev, mux_name, NULL, false);

mux_get() can only return NULL if optional is true.

    639 
--> 640         if (!mux)

this should be if (IS_ERR(mux)) {

    641                 return ERR_PTR(-ENOENT);
    642 
    643         return mux;
    644 }

This email is a free service from the Smatch-CI project [smatch.sf.net].

regards,
dan carpenter

                 reply	other threads:[~2026-04-10 10:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adjNEl0C8OgEjMI7@stanley.mountain \
    --to=error27@gmail.com \
    --cc=josua@solid-run.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox