From: Dan Carpenter <error27@gmail.com>
To: Manuel Ebner <manuelebner@mailbox.org>
Cc: kernel-janitors@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev,
linux-newbie@vger.kernel.org
Subject: Re: [PATCH] Documentation: adopt new coding style of type-aware kmalloc-family
Date: Sat, 18 Apr 2026 14:44:11 +0300 [thread overview]
Message-ID: <aeNui4yhFtLnIvSI@stanley.mountain> (raw)
In-Reply-To: <980be93ce680c831c37dbeeb070135b2fc8f4fb8.camel@mailbox.org>
On Sat, Apr 18, 2026 at 12:45:19PM +0200, Manuel Ebner wrote:
> On Sat, 2026-04-18 at 13:27 +0300, Dan Carpenter wrote:
> > On Sat, Apr 18, 2026 at 11:30:48AM +0200, Manuel Ebner wrote:
> > > Would a patch like this one make sense?
> > > I think i need help with the change log. Is there something to much or missing?
> > >
> > > ptr = kmalloc(sizeof(*ptr), gfp);
> > > -> ptr = kmalloc_obj(*ptr, gfp);
> > >
> > > This one is done. The ones below are not done yet.
> > >
> > > ptr = kmalloc(sizeof(struct some_obj_name), gfp);
> > > -> ptr = kmalloc_obj(*ptr, gfp);
> > > ptr = kzalloc(sizeof(*ptr), gfp);
> > > > ptr = kzalloc_obj(*ptr, gfp);
> > > ptr = kmalloc_array(count, sizeof(*ptr), gfp);
> > > -> ptr = kmalloc_objs(*ptr, count, gfp);
> > > ptr = kcalloc(count, sizeof(*ptr), gfp);
> > > -> ptr = kzalloc_objs(*ptr, count, gfp);
> > >
> > > change log:
> > > [PATCH] Documentation: adopt new coding style of type-aware kmalloc-family
> > >
> > > Update the documentation to reflect new type-aware kmalloc-family as
> > > suggested in commit 2932ba8d9c99 ("slab: Introduce kmalloc_obj() and family")
> > >
> > > ptr = kmalloc(sizeof(*ptr), gfp);
> > > -> ptr = kmalloc_obj(*ptr, gfp);
> > >
> > > Signed-off-by: Manuel Ebner <manuelebner@mailbox.org>
> >
> > Yeah. Fix up the commit message and that could probably be merged
> > through the documentation tree.
>
> how do i fix the commit message?
> what's even the issue?
I just meant that you should remove the stuff like "Would a patch like
this one make sense?"...
regards,
dan carpenter
prev parent reply other threads:[~2026-04-18 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-18 9:30 [PATCH] Documentation: adopt new coding style of type-aware kmalloc-family Manuel Ebner
2026-04-18 10:27 ` Dan Carpenter
2026-04-18 10:45 ` Manuel Ebner
2026-04-18 11:44 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeNui4yhFtLnIvSI@stanley.mountain \
--to=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-newbie@vger.kernel.org \
--cc=manuelebner@mailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox