Re: [patch] wireless: at76c50x: allocating too much data

Kalle Valo
2012-04-20T18:14:44Z

Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Fri, Apr 20, 2012 at 06:57:00PM +1000, Julian Calaby wrote:
>> > -       struct mib_local *m = kmalloc(sizeof(struct mib_phy), GFP_KERNEL);
>> > +       struct mib_local *m = kmalloc(sizeof(struct mib_local), GFP_KERNEL);
>>
>> Would it be better practice to use sizeof(*m)?
>>
>
> That was my temptation as well... But I decided to make it match
> with the surrounding code. I'm happy to resend if people want.

IMHO sizeof(*m) is better and I tend to use it.

Related to this: I have a bad habit of sometimes dropping '*' from
sizeof()? Is there a tool which could spot that?

--
Kalle Valo