Re: [patch] wireless: at76c50x: allocating too much data

Dan Carpenter
2012-04-20T09:14:49Z

On Fri, Apr 20, 2012 at 06:57:00PM +1000, Julian Calaby wrote:
> > -       struct mib_local *m = kmalloc(sizeof(struct mib_phy), GFP_KERNEL);
> > +       struct mib_local *m = kmalloc(sizeof(struct mib_local), GFP_KERNEL);
>
> Would it be better practice to use sizeof(*m)?
>

That was my temptation as well... But I decided to make it match
with the surrounding code. I'm happy to resend if people want.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html