From: Julia Lawall <julia.lawall@lip6.fr>
To: cocci@systeme.lip6.fr
Subject: Re: [PATCH] scripts/coccinelle: find constant additions that could be bit ors
Date: Sat, 23 Feb 2013 16:07:58 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1302231706060.2085@localhost6.localdomain6> (raw)
In-Reply-To: <20130223150521.GK9138@mwanda>
On Sat, 23 Feb 2013, Dan Carpenter wrote:
> On Fri, Feb 22, 2013 at 11:44:31AM +0100, Michal Marek wrote:
> > On Sat, Feb 02, 2013 at 05:19:55PM +0100, Julia Lawall wrote:
> > > From: Julia Lawall <Julia.Lawall@lip6.fr>
> > >
> > > Semantic patch (http://coccinelle.lip6.fr/) to check for constants that are
> > > added but are used elsewhere as bitmasks.
> > >
> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > Applied to kbuild.git#misc.
> >
>
> I'm not sure we want to do this. The one patch which was sent with
> this script wasn't applied.
I think that the view on it was that if it isn't broken, don't fix it.
But if the rules that are being added to the kernel are primarily being
used for new code, then it could be reasonable for developers to consider
whether they would really rather use | rather than the confusing +.
julia
prev parent reply other threads:[~2013-02-23 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 16:19 [PATCH] scripts/coccinelle: find constant additions that could be bit ors Julia Lawall
2013-02-22 10:44 ` Michal Marek
2013-02-23 15:05 ` Dan Carpenter
2013-02-23 16:07 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1302231706060.2085@localhost6.localdomain6 \
--to=julia.lawall@lip6.fr \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox