From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Wed, 07 Aug 2013 09:17:51 +0000 Subject: commas Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org There are a number of places where kernel code uses commas, where one might normally expect a semicolon. For example, drivers/cpufreq/sparc-us2e-cpufreq.c: driver->target = us2e_freq_target; driver->get = us2e_freq_get; driver->exit = us2e_freq_cpu_exit; driver->owner = THIS_MODULE, <------------- comma here strcpy(driver->name, "UltraSPARC-IIe"); cpufreq_us2e_driver = driver; ret = cpufreq_register_driver(driver); Is there any reason for this? I guess that they are not very harmful, but if one happens to write a static checker rule that expects a ;, then this code will be overlooked. julia