From: Julia Lawall <julia.lawall@lip6.fr>
To: Richard Genoud <richard.genoud@gmail.com>
Cc: trivial@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: convert comma to semicolon
Date: Fri, 09 Aug 2013 15:16:41 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1308091715310.2295@hadrien> (raw)
In-Reply-To: <CACQ1gAg__bY9pCnGnkf2QGHkBvssXXdS3bMJiuOJfh9e082jhA@mail.gmail.com>
On Fri, 9 Aug 2013, Richard Genoud wrote:
> > diff --git a/drivers/clocksource/time-armada-370-xp.c b/drivers/clocksource/time-armada-370-xp.c
> > index 847cab6..8149b7b 100644
> > --- a/drivers/clocksource/time-armada-370-xp.c
> > +++ b/drivers/clocksource/time-armada-370-xp.c
> > @@ -175,10 +175,10 @@ static int armada_370_xp_timer_setup(struct clock_event_device *evt)
> > evt->name = "armada_370_xp_per_cpu_tick",
> There's one missed just here ! ^
>
> > evt->features = CLOCK_EVT_FEAT_ONESHOT |
> > CLOCK_EVT_FEAT_PERIODIC;
> > - evt->shift = 32,
> > - evt->rating = 300,
> > - evt->set_next_event = armada_370_xp_clkevt_next_event,
> > - evt->set_mode = armada_370_xp_clkevt_mode,
> > + evt->shift = 32;
> > + evt->rating = 300;
> > + evt->set_next_event = armada_370_xp_clkevt_next_event;
> > + evt->set_mode = armada_370_xp_clkevt_mode;
> > evt->irq = armada_370_xp_clkevt_irq;
> > evt->cpumask = cpumask_of(cpu);
> >
> [snip]
>
> The rest looks good to me !
Thanks for the feedback. I was going to try to make a patch that does
everything that this one does not, but it is not working out very well, so
I will make a new patch that does everything.
julia
next prev parent reply other threads:[~2013-08-09 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 19:32 [PATCH] convert comma to semicolon Julia Lawall
2013-08-08 19:32 ` [PATCH] trivial: " Julia Lawall
2013-08-09 7:39 ` Richard Genoud
2013-08-09 15:16 ` Julia Lawall [this message]
2013-08-08 19:43 ` [PATCH] " Joe Perches
2013-08-08 19:45 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1308091715310.2295@hadrien \
--to=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.genoud@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox