Re: [PATCH 5/6] regulator: ti-abb: simplify platform_get_resource_byname/devm_ioremap_resource

walter harms
2013-08-19T09:10:41Z

Am 19.08.2013 10:51, schrieb Julia Lawall:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Remove unneeded error handling on the result of a call to
> platform_get_resource_byname when the value is passed to devm_ioremap_resource.
>
> A simplified version of the semantic patch that makes this change is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression pdev,res,e,e1;
> expression ret != 0;
> identifier l;
> @@
>
> res = platform_get_resource_byname(...);
> - if (res = NULL) { ... \(goto l;\|return ret;\) }
> e = devm_ioremap_resource(e1, res);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/regulator/ti-abb-regulator.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c
> index 3753ed0..d8e3e12 100644
> --- a/drivers/regulator/ti-abb-regulator.c
> +++ b/drivers/regulator/ti-abb-regulator.c
> @@ -717,11 +717,6 @@ static int ti_abb_probe(struct platform_device *pdev)
> /* Map ABB resources */
> pname = "base-address";
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
> - if (!res) {
> - dev_err(dev, "Missing '%s' IO resource\n", pname);
> - ret = -ENODEV;
> - goto err;
> - }
> abb->base = devm_ioremap_resource(dev, res);
> if (IS_ERR(abb->base)) {
> ret = PTR_ERR(abb->base);

is pname used by anything else ? (also below)

re,
wh

> @@ -770,11 +765,6 @@ static int ti_abb_probe(struct platform_device *pdev)
>
> pname = "ldo-address";
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM, pname);
> - if (!res) {
> - dev_dbg(dev, "Missing '%s' IO resource\n", pname);
> - ret = -ENODEV;
> - goto skip_opt;
> - }
> abb->ldo_base = devm_ioremap_resource(dev, res);
> if (IS_ERR(abb->ldo_base)) {
> ret = PTR_ERR(abb->ldo_base);
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>