From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 19 Aug 2013 12:00:37 +0000 Subject: Re: [PATCH 4/6] usb: musb: dsps: simplify platform_get_resource_byname/devm_ioremap_resource Message-Id: MIME-Version: 1 Content-Type: multipart/mixed; boundary="8323329-2032609312-1376913637=:2313" List-Id: References: <1376902316-18520-1-git-send-email-Julia.Lawall@lip6.fr> <1376902316-18520-5-git-send-email-Julia.Lawall@lip6.fr> <5211FED3.4090102@secomea.dk> <521208A0.5010602@secomea.dk> In-Reply-To: <521208A0.5010602@secomea.dk> To: =?ISO-8859-15?Q?Svenning_S=F8rensen?= Cc: Felipe Balbi , kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2032609312-1376913637=:2313 Content-Type: TEXT/PLAIN; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Mon, 19 Aug 2013, Svenning S=F8rensen wrote: > > On 19-08-2013 13:35, Julia Lawall wrote: > > reg_base =3D devm_ioremap_resource(dev, r); > > if (!musb->ctrl_base) > > return -EINVAL; > > > Not really related to Julia's patch, apart from making it more obvious > > > that > > > there's a bug here. > > > I believe it is reg_base that needs to be checked, right? > > Indeed, it is all backwards. I could extend the patch, if you want. > > > I'll let Felipe decide on that, but I can't imagine any objections. > IS_ERR() is the proper test, of course :) I've already sent a patch, in case it is useful. julia --8323329-2032609312-1376913637=:2313--