From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Date: Wed, 28 May 2014 20:42:51 +0000 Subject: Re: [PATCH] perf/x86/uncore: Remove unnecessary assignment to "box" in uncore_pci_remove(...) Message-Id: List-Id: References: <1401268294-28634-1-git-send-email-giedrius.rekasius@gmail.com> <5385B764.6090301@bfs.de> In-Reply-To: <5385B764.6090301@bfs.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: walter harms Cc: Giedrius Rekasius , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Wed, 28 May 2014, walter harms wrote: > Am 28.05.2014 11:11, schrieb Giedrius Rekasius: > > Local variable "box" gets assigned correct value when it is initialized. > > There is no need to assign the same value again. > > > > Signed-off-by: Giedrius Rekasius > > --- > > arch/x86/kernel/cpu/perf_event_intel_uncore.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c > > index 65bbbea..8cbbb1b 100644 > > --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c > > +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c > > @@ -3817,7 +3817,6 @@ static void uncore_pci_remove(struct pci_dev *pdev) > > struct intel_uncore_pmu *pmu; > > int i, cpu, phys_id = pcibus_to_physid[pdev->bus->number]; > > > > - box = pci_get_drvdata(pdev); > > if (!box) { > > for (i = 0; i < UNCORE_EXTRA_PCI_DEV_MAX; i++) { > > if (extra_pci_dev[phys_id][i] = pdev) { > > Just a remark, > for readability it is better to remove the other one. I rather have stuff reshuffled a bit more: static void uncore_pci_remove(struct pci_dev *pdev) { int i, cpu, phys_id = pcibus_to_physid[pdev->bus->number]; struct intel_uncore_box *box = pci_get_drvdata(pdev); struct intel_uncore_pmu *pmu; if (!box) { That's less lines and entirely readable. Thanks, tglx