Re: [PATCH 1/8] fs/9p: Deletion of unnecessary checks before the function call "p9_client_clunk"

Dan Carpenter
2015-01-05T11:22:06Z

On Sun, Dec 28, 2014 at 09:40:25PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sat, 27 Dec 2014 09:34:39 +0100
>
> The p9_client_clunk() function tests whether its argument is NULL
> and then returns immediately. Thus the test around the call is not needed.
>

Not true. You are not allowed to call p9_client_clunk(NULL). I assume
this patch adds a bug. You have tried to introduce several of these
kinds of bugs. You are not careful enough.

regards,
dan carpenter