Re: [PATCH] staging: gdm72xx: Deletion of an unnecessary check before the function call "kfree"

Greg Kroah-Hartman
2015-02-01T18:12:36Z

On Sun, Feb 01, 2015 at 06:42:53PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 1 Feb 2015 18:28:33 +0100
>
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/staging/gdm72xx/gdm_wimax.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/staging/gdm72xx/gdm_wimax.c
> index 9cab54b..ac901e6 100644
> --- a/drivers/staging/gdm72xx/gdm_wimax.c
> +++ b/drivers/staging/gdm72xx/gdm_wimax.c
> @@ -362,7 +362,7 @@ static int gdm_wimax_close(struct net_device *dev)
>
> static void kdelete(void **buf)
> {
> - if (buf && *buf) {
> + if (buf) {
> kfree(*buf);
> *buf = NULL;
> }

Instead we should delete this function and have the driver use the
"correct" kfree calls instead, right? That extra setting the buffer to
NULL is a waste for most of these calls.

thanks,

greg k-h