Re: [Cocci] [PATCH 1/1] kernel-audit: Deletion of an unnecessary check before the function call "aud

Julia Lawall
2014-11-23T11:51:51Z

> > No, it's not. You should just try to write the most readable software
> > you can instead of removing if statements because you can.
>
> Additional safety checks have also got an effect on source code readability, haven't they?

Normally, tests only hurt readability if they cannot be false or cannot be
true. Making a choice apparent when there really is a choice would seem
to aid understanding. Program analysis tools can also potentially exploit
this information, which you are so systmatically removing.

julia