Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical()

SF Markus Elfring
2014-11-13T08:50:32Z

>>>> + goto cleanup1;
>>>
>>> 1) Don't use GW-BASIC label names. Label names should reflect what the
>>> label does such as free_fuse_word or free_fuse_tabel.
>>>
>>> 2) Don't use do-nothing labels. Just return directly.
>>
>> Does the document "CodingStyle" need any extensions for special cases?
>
> I don't understand.

Should the naming convention become more explicit for jump labels?

> CodingStyle says:
>
> "If there is no cleanup needed then just return directly."

Do you want that I send another update suggestion with other corrections
for jump labels in the affected function implementation?

Regards,
Markus