Re: [osd-dev] [PATCH 1/1] exofs: Deletion of an unnecessary check before the function call "ore_put_

SF Markus Elfring
2015-06-26T15:48:03Z

>> From: Markus Elfring <elfring@users.sourceforge.net>
>> Date: Tue, 18 Nov 2014 10:05:19 +0100
>>
>> The ore_put_io_state() function tests whether its argument is NULL and then
>> returns immediately. Thus the test around the call is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
>> ---
>> fs/exofs/ore_raid.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/exofs/ore_raid.c b/fs/exofs/ore_raid.c
>> index 84529b8..5dc7c4c 100644
>> --- a/fs/exofs/ore_raid.c
>> +++ b/fs/exofs/ore_raid.c
>> @@ -716,6 +716,5 @@ void _ore_free_raid_stuff(struct ore_io_state *ios)
>> if (ios->extra_part_alloc)
>> kfree(ios->per_dev[0].sglist);
>> }
>> - if (ios->ios_read_4_write)
>> - ore_put_io_state(ios->ios_read_4_write);
>> + ore_put_io_state(ios->ios_read_4_write);
>> }
>>
>
> Thanks will submit for next Kernel

Is this small update suggestion still in the waiting queue
for further software improvements?

Regards,
Markus