Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure

SF Markus Elfring
2015-06-29T06:02:50Z

> tcegrp will be NULL and kfree() can handle this just fine

The affected function did not show this API knowledge, did it?

> (is not it the whole point of this patchset
> - remove the check and just call kfree() even if the pointer is NULL?).

Partly, yes.

> And if you wanted another label,

I suggest this to improve corresponding exception handling.

> than the existing one should have been renamed to "free_exit" or "free_unlock_exit"
> and new one would be "unlock_exit".

I chose a smaller change at this place.

I am not familiar enough with other called functions there at the moment.
Are the remaining goto statements also update candidates?

Regards,
Markus