From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Wed, 03 Dec 2014 10:36:20 +0000 Subject: Re: [patch] mpt2sas: issue reset is not uninitialized Message-Id: List-Id: References: <20141203100941.GB29583@mwanda> In-Reply-To: <20141203100941.GB29583@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Nagalakshmi Nandigama , Praveen Krishnamoorthy , Sreekanth Reddy , Abhijit Mahajan , "James E.J. Bottomley" , MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, quentin.lambert@inria.fr On Wed, 3 Dec 2014, Dan Carpenter wrote: > The issue_reset variables were never set to zero. This bug was found > with static analysis. > > Signed-off-by: Dan Carpenter > > diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c > index 58e4521..98bd546 100644 > --- a/drivers/scsi/mpt2sas/mpt2sas_base.c > +++ b/drivers/scsi/mpt2sas/mpt2sas_base.c > @@ -3236,7 +3236,7 @@ mpt2sas_base_sas_iounit_control(struct MPT2SAS_ADAPTER *ioc, > u16 smid; > u32 ioc_state; > unsigned long timeleft; > - u8 issue_reset; > + bool issue_reset = 0; Why not false if it is going to be a boolean? julia > int rc; > void *request; > u16 wait_state_count; > @@ -3341,7 +3341,7 @@ mpt2sas_base_scsi_enclosure_processor(struct MPT2SAS_ADAPTER *ioc, > u16 smid; > u32 ioc_state; > unsigned long timeleft; > - u8 issue_reset; > + bool issue_reset = 0; > int rc; > void *request; > u16 wait_state_count; > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >