From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julia Lawall <julia.lawall@lip6.fr>
Date: Wed, 08 Apr 2015 09:51:42 +0000
Subject: Re: [patch] ext4 crypto: testing the wrong variable
Message-Id: <alpine.DEB.2.10.1504081150401.9503@hadrien>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20150408085338.GA8837@mwanda>
In-Reply-To: <20150408085338.GA8837@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Theodore Ts'o <tytso@mit.edu>, Michael Halcrow <mhalcrow@google.com>, Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org

>  void ext4_fname_crypto_free_buffer(void **buf)
>  {
> -	if (*buf = NULL || IS_ERR(buf))
> +	if (*buf = NULL || IS_ERR(*buf))

Why not use IS_ERR_OR_NULL?

julia

>  		return;
>  	kfree(*buf);
>  	*buf = NULL;
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>