From: Julia Lawall <julia.lawall@lip6.fr>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 08/15] adfs:Remove unneeded kmem_cache_alloc() return value cast
Date: Thu, 23 Apr 2015 05:43:27 +0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1504230741410.2812@hadrien> (raw)
In-Reply-To: <1429767245-32453-9-git-send-email-firogm@gmail.com>
Sorry to be picky, but normally people put a space after the colon. Also,
the subject line could be shorter: Remove unneeded cast. The description
part of the subject doesn't have to be unique, just the whole thing,
asfter the [PATCH] part.
julia
On Thu, 23 Apr 2015, Firo Yang wrote:
> kmem_cache_alloc() returns a void pointer - no need to cast it in
> fs/adfs/super.c::adfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> ---
> fs/adfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/adfs/super.c b/fs/adfs/super.c
> index a19c31d..4d4a0df 100644
> --- a/fs/adfs/super.c
> +++ b/fs/adfs/super.c
> @@ -242,7 +242,7 @@ static struct kmem_cache *adfs_inode_cachep;
> static struct inode *adfs_alloc_inode(struct super_block *sb)
> {
> struct adfs_inode_info *ei;
> - ei = (struct adfs_inode_info *)kmem_cache_alloc(adfs_inode_cachep, GFP_KERNEL);
> + ei = kmem_cache_alloc(adfs_inode_cachep, GFP_KERNEL);
> if (!ei)
> return NULL;
> return &ei->vfs_inode;
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-04-23 5:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 5:33 [PATCH 08/15] adfs:Remove unneeded kmem_cache_alloc() return value cast Firo Yang
2015-04-23 5:43 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1504230741410.2812@hadrien \
--to=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox