From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Fri, 11 Dec 2015 12:14:51 +0000 Subject: Re: Source code review around jump label usage Message-Id: List-Id: References: <566ABCD9.1060404@users.sourceforge.net> In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: LKML , kernel-janitors@vger.kernel.org, "Derek M. Jones" > Do any of these numbers indicate update candidates which correspond to the > "one error jump label bug" symptom that is mentioned in the Linux coding > style documentation? I don't think that numbers could indicate that. The point of that is a single label followed by a bunch of ifs, or by calls to functions that perform tests on input validity. That is, it is the content of the code that causes the problem, not its size. Dan also discourages the use of labels like out, that don't indicate anything about anything, or kmalloc_err, which don't indicate anything about what happens at the label target. julia