Re: [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection

SF Markus Elfring
2015-12-28T10:30:46Z

>> Move the jump label directly before the desired log statement
>> so that the variable "ret" will not be checked once more
>> after it was determined that a function call failed.
>
> Why not avoid both unnecessary ifs

I would find such a fine-tuning also nice in principle at more source code places.

> and the enormous ugliness of a label inside an if by making two returns:
> a return 0 for success and a dev_dbg and return ret for failure?

How should your suggestion finally work when the desired execution success
can be determined for such functions only after several other calls succeeded?

Is consistent checking of failure predicates usually required?

Regards,
Markus