[PATCH 3/7] ACPI-APEI-HEST: Move an assignment in hest_ghes_dev_register()

SF Markus Elfring
2016-09-05T20:18:21Z

Date: Mon, 5 Sep 2016 21:15:22 +0200

Move one assignment for a data structure member in one local variable
so that its setting will only be performed after a corresponding memory
allocation succeeded by this function.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/acpi/apei/hest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index a852237..26f5e78 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -185,13 +185,13 @@ static int __init hest_ghes_dev_register(unsigned int ghes_count)
int rc, i;
struct ghes_arr ghes_arr;

- ghes_arr.count = 0;
ghes_arr.ghes_devs = kmalloc_array(ghes_count,
sizeof(*ghes_arr.ghes_devs),
GFP_KERNEL);
if (!ghes_arr.ghes_devs)
return -ENOMEM;

+ ghes_arr.count = 0;
rc = apei_hest_parse(hest_parse_ghes, &ghes_arr);
if (rc)
goto err;
--
2.10.0