Re: [PATCH 0/2] GPU-DRM-Savage: Fine-tuning for savage_bci_cmdbuf()

Daniel Vetter
2016-08-19T07:41:10Z

On Thu, Aug 18, 2016 at 09:42:33PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 18 Aug 2016 21:38:37 +0200
>
> A few update suggestions were taken into account
> from static source code analysis.

savage is one of the dri1 legacy drivers, imo not really worth it to spend
time on them. otoh no one will notice any breakage either ;-)

I guess I'll apply.
-Daniel

>
> Markus Elfring (2):
> Use memdup_user() rather than duplicating its implementation
> Less function calls after error detection
>
> drivers/gpu/drm/savage/savage_state.c | 42 +++++++++++++++--------------------
> 1 file changed, 18 insertions(+), 24 deletions(-)
>
> --
> 2.9.3
>

--
Daniel Vetter
Software Engineer, Intel Corporation