Re: [PATCH 2/2] 390/qeth: Refactoring for qeth_core_set_online()

Heiko Carstens
2016-01-04T11:30:46Z

On Sun, Jan 03, 2016 at 11:02:56AM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 3 Jan 2016 10:50:11 +0100
>
> Reduce the scope for the local variable "def_discipline" to one branch
> of an if statement.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/s390/net/qeth_core_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 54fde2e..3261977 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -5638,9 +5638,10 @@ static int qeth_core_set_online(struct ccwgroup_device *gdev)
> {
> struct qeth_card *card = dev_get_drvdata(&gdev->dev);
> int rc;
> - int def_discipline;
>
> if (!card->discipline) {
> + int def_discipline;
> +
> if (card->info.type = QETH_CARD_TYPE_IQD)
> def_discipline = QETH_DISCIPLINE_LAYER3;

Same here: I don't think we want to start with patches like this. This
going to be a never ending story without much benefit.