From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Mon, 28 Dec 2015 10:36:03 +0000 Subject: Re: [media] tuners: One check less in m88rs6000t_get_rf_strength() after error detection Message-Id: List-Id: References: <566ABCD9.1060404@users.sourceforge.net> <5680FDB3.7060305@users.sourceforge.net> <56810F56.4080306@users.sourceforge.net> In-Reply-To: <56810F56.4080306@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: linux-media@vger.kernel.org, Mauro Carvalho Chehab , LKML , kernel-janitors@vger.kernel.org On Mon, 28 Dec 2015, SF Markus Elfring wrote: > >> Move the jump label directly before the desired log statement > >> so that the variable "ret" will not be checked once more > >> after it was determined that a function call failed. > > > > Why not avoid both unnecessary ifs > > I would find such a fine-tuning also nice in principle at more source code places. > > > > and the enormous ugliness of a label inside an if by making two returns: > > a return 0 for success and a dev_dbg and return ret for failure? > > How should your suggestion finally work when the desired execution success > can be determined for such functions only after several other calls succeeded? Not idea what this means, but immediate return 0 followed by various code for reacting to an error is very common, so it looks like it should be possible here. julia