From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 26 May 2016 14:15:17 +0000 Subject: Re: [patch v2] PM / devfreq: exynos-nocp: Remove incorrect IS_ERR() check Message-Id: List-Id: References: <20160526064541.GA6680@mwanda> <5746AFE3.6030606@samsung.com> <20160526115629.GD10957@mwanda> <20160526135600.GE10957@mwanda> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cw00.choi@samsung.com Cc: Dan Carpenter , Julia Lawall , MyungJoo Ham , Kyungmin Park , Kukjin Kim , Krzysztof Kozlowski , "linux-pm@vger.kernel.org" , linux-samsung-soc , kernel-janitors@vger.kernel.org On Thu, 26 May 2016, Chanwoo Choi wrote: > On Thu, May 26, 2016 at 10:56 PM, Dan Carpenter > wrote: > > On Thu, May 26, 2016 at 10:46:26PM +0900, Chanwoo Choi wrote: > >> On Thu, May 26, 2016 at 8:56 PM, Dan Carpenter wrote: > >> > On Thu, May 26, 2016 at 05:12:19PM +0900, Chanwoo Choi wrote: > >> >> I don't recommend that you mention the name of engineer on patch description > >> >> directly. > >> > > >> > This really is normal. I've been mentioned over 100 times in commit > >> > messages like 7051924f771 (xillybus: Move out of staging). > >> > >> I'm still reluctant to use the name on description. > > > > I understand that but I don't understand why, though. Anyway, aren't > > forwarding this to someone? You can change it to say whatever you want. > > Because if the name without any unique email address is included in > the description, I sent a Reviewed-by, so this issue is solved. julia > I think that it is not appropriate. Always, the information should > include the email address. > So, I just prefer to use the Suggested-by or the different kind of tag > with [id: explanation]. > > But, I'll stop about it because it is not critical issue. > It depend on what is the preferred method to add the information. > > Thanks, > Chanwoo Choi > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >