From: Julia Lawall <julia.lawall@lip6.fr>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 07/11 v2] phy: qcom-ufs: use of_property_read_bool
Date: Fri, 05 Aug 2016 11:25:13 +0000 [thread overview]
Message-ID: <alpine.DEB.2.10.1608051324260.2999@hadrien> (raw)
In-Reply-To: <1470387411-15879-8-git-send-email-Julia.Lawall@lip6.fr>
Use of_property_read_bool to check for the existence of a property.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,x;
@@
- if (of_get_property(e1,e2,NULL))
- x = true;
- else
- x = false;
+ x = of_property_read_bool(e1,e2);
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
v2: special case for propagating true and false
drivers/phy/phy-qcom-ufs.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
index 107cb57..18a5b49 100644
--- a/drivers/phy/phy-qcom-ufs.c
+++ b/drivers/phy/phy-qcom-ufs.c
@@ -283,10 +283,8 @@ static int __ufs_qcom_phy_init_vreg(struct phy *phy,
err = 0;
}
snprintf(prop_name, MAX_PROP_NAME, "%s-always-on", name);
- if (of_get_property(dev->of_node, prop_name, NULL))
- vreg->is_always_on = true;
- else
- vreg->is_always_on = false;
+ vreg->is_always_on = of_property_read_bool(dev->of_node,
+ prop_name);
}
if (!strcmp(name, "vdda-pll")) {
next prev parent reply other threads:[~2016-08-05 11:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 8:56 [PATCH 00/11] use of_property_read_bool Julia Lawall
2016-08-05 8:56 ` [PATCH 01/11] fsl/qe: " Julia Lawall
2016-08-05 8:56 ` [PATCH 02/11] usb: host: fsl-mph-dr-of: " Julia Lawall
2016-08-05 11:26 ` [PATCH 02/11 v2] " Julia Lawall
2016-08-05 8:56 ` [PATCH 03/11] pinctrl: nomadik: " Julia Lawall
2016-08-05 11:26 ` [PATCH 03/11 v2] " Julia Lawall
2016-08-11 11:52 ` [PATCH 03/11] " Linus Walleij
2016-08-05 8:56 ` [PATCH 04/11] i2c: mpc: " Julia Lawall
2017-10-27 20:15 ` [04/11] " Wolfram Sang
2016-08-05 8:56 ` [PATCH 05/11] tty/serial: at91: " Julia Lawall
2016-08-05 8:56 ` [PATCH 06/11] mmc: sdhci-of-esdhc: " Julia Lawall
2016-08-18 7:36 ` Adrian Hunter
2016-08-22 13:39 ` Ulf Hansson
2016-08-05 8:56 ` [PATCH 07/11] phy: qcom-ufs: " Julia Lawall
2016-08-05 11:25 ` Julia Lawall [this message]
2016-08-12 10:14 ` [PATCH 07/11 v2] " Kishon Vijay Abraham I
2016-08-05 8:56 ` [PATCH 08/11] net/fsl: " Julia Lawall
2016-08-05 9:30 ` Johannes Berg
2016-08-05 9:47 ` Julia Lawall
2016-08-05 10:08 ` Julia Lawall
2016-08-05 10:12 ` Johannes Berg
2016-08-05 10:14 ` Julia Lawall
2016-08-05 11:24 ` [PATCH 08/11 v2] " Julia Lawall
2016-08-05 11:35 ` [PATCH 08/11] " Sergei Shtylyov
2016-08-05 11:38 ` Julia Lawall
2016-08-05 11:40 ` Sergei Shtylyov
2016-08-05 8:56 ` [PATCH 09/11] powerpc/mpic: " Julia Lawall
2016-08-08 6:37 ` Michael Ellerman
2016-08-05 8:56 ` [PATCH 10/11] soc: ti: knav_qmss_queue: " Julia Lawall
2016-08-05 12:47 ` Robin Murphy
2016-08-05 12:59 ` Julia Lawall
2016-08-05 8:56 ` [PATCH 11/11] ASoC: " Julia Lawall
2016-08-05 12:09 ` Applied "ASoC: use of_property_read_bool" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1608051324260.2999@hadrien \
--to=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox