Re: [PATCH 14/15] irqchip/metag-ext: improve function-level documentation

James Hogan
2016-10-01T20:33:51Z

Hi Julia,

On 1 October 2016 at 20:46, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> Drop the variable irq which ceased to be a parameter in bd0b9ac4.

I think 12 nibbles of the hash is recommended now due to collisions,
as is quoting the subject line, e.g. commit bd0b9ac405e1 ("genirq:
Remove irq argument from irq flow handlers").

>
> Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

Acked-by: James Hogan <james.hogan@imgtec.com>

Thanks
James

>
> ---
> drivers/irqchip/irq-metag-ext.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/irqchip/irq-metag-ext.c b/drivers/irqchip/irq-metag-ext.c
> index 8c38b3d..0cdd923 100644
> --- a/drivers/irqchip/irq-metag-ext.c
> +++ b/drivers/irqchip/irq-metag-ext.c
> @@ -436,7 +436,6 @@ static int meta_intc_irq_set_type(struct irq_data *data, unsigned int flow_type)
>
> /**
> * meta_intc_irq_demux() - external irq de-multiplexer
> - * @irq: the virtual interrupt number
> * @desc: the interrupt description structure for this irq
> *
> * The cpu receives an interrupt on TR2 when a SoC interrupt has occurred. It is
>