From: Julia Lawall <julia.lawall@lip6.fr>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
kernel-janitors@vger.kernel.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/15] ASoC: omap-mcbsp: use permission-specific DEVICE_ATTR variants
Date: Sun, 30 Oct 2016 11:50:12 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1610301246120.2074@hadrien> (raw)
In-Reply-To: <20161030125851.bd0e74854c52ce7d4ab3570c@bitmer.com>
On Sun, 30 Oct 2016, Jarkko Nikula wrote:
> Hi
>
> On Sat, 29 Oct 2016 21:37:04 +0200
> Julia Lawall <Julia.Lawall@lip6.fr> wrote:
>
> > Use DEVICE_ATTR_RW for read-write attributes. This simplifies the
> > source code, improves readbility, and reduces the chance of
> > inconsistencies.
> >
> ...
> >
> > - DEVICE_ATTR(x, \(0644\|S_IRUGO|S_IWUSR\), x_show, x_store);
> > + DEVICE_ATTR_RW(x);
>
> I'm not so sure does this improve readability. 644 is pretty obvious but
> for DEVICE_ATTR_RW() one has to dive into include/linux/device.h and
> include/linux/sysfs.h to see for what users it grants the write access.
OK, as you like. It does help ensure that the functions that are supposed
to be defined are available. There were a couple of occurrences of 0644
with no show or no store function. Among the three declarers, there are
currently in total over 800 uses in the kernel, so they are also not so
obscure.
julia
next prev parent reply other threads:[~2016-10-30 11:50 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 19:36 [PATCH 00/15] use permission-specific DEVICE_ATTR variants Julia Lawall
2016-10-29 19:36 ` [PATCH 01/15] wusbcore: dev-sysfs: " Julia Lawall
2016-10-29 19:36 ` [PATCH 02/15] wusbcore: wusbhc: " Julia Lawall
2016-10-29 19:36 ` [PATCH 03/15] wm8350_power: " Julia Lawall
2016-10-30 15:03 ` Charles Keepax
2016-11-23 23:10 ` Sebastian Reichel
2016-10-29 19:36 ` [PATCH 04/15] video: fbdev: " Julia Lawall
2017-01-11 16:06 ` Bartlomiej Zolnierkiewicz
2016-10-29 19:36 ` [PATCH 05/15] MIPS: TXx9: 7segled: " Julia Lawall
2016-10-29 19:37 ` [PATCH 06/15] thermal: int340x_thermal: " Julia Lawall
2016-10-29 19:37 ` [PATCH 07/15] thermal: hwmon: " Julia Lawall
2016-10-29 19:37 ` [PATCH 08/15] powerpc/iommu: " Julia Lawall
2016-10-31 6:06 ` Michael Ellerman
2017-09-01 13:29 ` [08/15] " Michael Ellerman
2016-10-29 19:37 ` [PATCH 09/15] arch/tile: " Julia Lawall
2016-10-29 19:37 ` [PATCH 10/15] ASoC: omap-mcbsp: " Julia Lawall
2016-10-30 10:58 ` Jarkko Nikula
2016-10-30 11:50 ` Julia Lawall [this message]
2016-10-29 19:37 ` [PATCH 11/15] ASoC: dapm: " Julia Lawall
2016-10-29 19:37 ` [PATCH 12/15] ptp: " Julia Lawall
2016-10-31 9:30 ` Richard Cochran
2016-10-31 19:32 ` David Miller
2016-10-29 19:37 ` [PATCH 13/15] PCI/ASPM: " Julia Lawall
2016-11-14 21:40 ` Bjorn Helgaas
2016-11-14 21:52 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 14/15] tty: nozomi: " Julia Lawall
2016-10-29 19:37 ` [PATCH 15/15] solos-pci: " Julia Lawall
2016-10-31 19:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1610301246120.2074@hadrien \
--to=julia.lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox