From: Julia Lawall <julia.lawall@lip6.fr>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
jpinto <Joao.Pinto@synopsys.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch net-next] stmmac: indent an if statement
Date: Thu, 12 Jan 2017 19:46:05 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1701122045460.1988@hadrien> (raw)
In-Reply-To: <20170112184631.GA12157@mwanda>
On Thu, 12 Jan 2017, Dan Carpenter wrote:
> The break statement should be indented one more tab.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index ac32f9e..4daa8a3 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -191,7 +191,7 @@ static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
> for_each_child_of_node(np, plat->mdio_node) {
> if (of_device_is_compatible(plat->mdio_node,
> "snps,dwmac-mdio"))
> - break;
> + break;
If there is a break, there is probably also a need for an of_node_put?
julia
> }
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-01-12 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-12 18:46 [patch net-next] stmmac: indent an if statement Dan Carpenter
2017-01-12 19:46 ` Julia Lawall [this message]
2017-01-16 3:14 ` David Miller
2017-01-16 9:19 ` Dan Carpenter
2017-01-16 9:39 ` Dan Carpenter
2017-01-16 21:46 ` Julia Lawall
2017-01-16 21:56 ` Dan Carpenter
2017-01-16 22:00 ` David Miller
2017-01-17 8:28 ` Alexandre Torgue
2017-01-16 22:10 ` Julia Lawall
2017-01-17 8:25 ` Alexandre Torgue
2017-01-17 11:45 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1701122045460.1988@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Joao.Pinto@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox