From: Julia Lawall <julia.lawall@lip6.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Julia Lawall <julia.lawall@lip6.fr>,
linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [media] spca500: Use common error handling code in spca500_synch310()
Date: Fri, 22 Sep 2017 17:41:13 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1709221941020.3170@hadrien> (raw)
In-Reply-To: <4921ea61-49cd-4071-e636-c199daddec8e@users.sourceforge.net>
On Fri, 22 Sep 2017, SF Markus Elfring wrote:
> >> return 0;
> >> -error:
> >> +
> >> +report_failure:
> >> + PERR("Set packet size: set interface error");
> >> return -EBUSY;
> >> }
> >
> > Why change the label name?
>
> I find the suggested variant a bi better.
>
>
> > They are both equally uninformative.
>
> Which identifier would you find appropriate there?
error was fine.
julia
next prev parent reply other threads:[~2017-09-22 17:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 17:06 [PATCH] [media] spca500: Use common error handling code in spca500_synch310() SF Markus Elfring
2017-09-22 17:09 ` Julia Lawall
2017-09-22 17:40 ` SF Markus Elfring
2017-09-22 17:41 ` Julia Lawall [this message]
2017-09-22 17:46 ` SF Markus Elfring
2017-09-22 18:27 ` Daniele Nicolodi
2017-09-22 20:44 ` SF Markus Elfring
2017-09-22 18:37 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709221941020.3170@hadrien \
--to=julia.lawall@lip6.fr \
--cc=elfring@users.sourceforge.net \
--cc=hverkuil@xs4all.nl \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox