From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Fri, 22 Sep 2017 17:41:13 +0000 Subject: Re: [media] spca500: Use common error handling code in spca500_synch310() Message-Id: List-Id: References: <4921ea61-49cd-4071-e636-c199daddec8e@users.sourceforge.net> In-Reply-To: <4921ea61-49cd-4071-e636-c199daddec8e@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring Cc: Julia Lawall , linux-media@vger.kernel.org, Hans Verkuil , Mauro Carvalho Chehab , Sakari Ailus , LKML , kernel-janitors@vger.kernel.org On Fri, 22 Sep 2017, SF Markus Elfring wrote: > >> return 0; > >> -error: > >> + > >> +report_failure: > >> + PERR("Set packet size: set interface error"); > >> return -EBUSY; > >> } > > > > Why change the label name? > > I find the suggested variant a bi better. > > > > They are both equally uninformative. > > Which identifier would you find appropriate there? error was fine. julia