From: Julia Lawall <julia.lawall@lip6.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, Jan Kara <jack@suse.cz>,
Lorenzo Stoakes <lstoakes@gmail.com>,
Michal Hocko <mhocko@suse.com>,
Muralidharan Karicheri <mkaricheri@gmail.com>,
Vaibhav Hiremath <hvaibhav@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: Adjustments for a lot of function implementations
Date: Mon, 30 Oct 2017 09:47:01 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1710301745530.2160@hadrien> (raw)
In-Reply-To: <14619198-bebe-d215-5324-a14fbc2103fb@users.sourceforge.net>
On Mon, 30 Oct 2017, SF Markus Elfring wrote:
> > While we do not mind cleanup patches, the way you post them (one fix per file)
>
> I find it safer in this way while I was browsing through the landscape of Linux
> software components.
>
>
> > is really annoying and takes us too much time to review.
>
> It is just the case that there are so many remaining open issues.
>
>
> > I'll take the "Fix a possible null pointer" patch since it is an actual bug fix,
>
> Thanks for a bit of change acceptance.
>
>
> > but will reject the others, not just this driver but all of them that are currently
> > pending in our patchwork (https://patchwork.linuxtv.org).
>
> Will any chances evolve to integrate 146 patches in any other combination?
>
>
> > Feel free to repost, but only if you organize the patch as either fixing the same type of
> > issue for a whole subdirectory (media/usb, media/pci, etc)
Just for the record, while this may work for media, it won't work for all
subsystems. One will quickly get a complaint that the big patch needs to
go into multiple trees.
julia
>
> Can we achieve an agreement on the shown change patterns?
>
> Is a consensus possible for involved update candidates?
>
>
> > or fixing all issues for a single driver.
>
> I find that I did this already.
>
>
> > Actual bug fixes (like the null pointer patch in this series) can still be posted as
> > separate patches, but cleanups shouldn't.
>
> I got an other software development opinion.
>
>
> > Just so you know, I'll reject any future patch series that do not follow these rules.
> > Just use common sense when posting these things in the future.
>
> Do we need to try any additional communication tools out?
>
>
> > I would also suggest that your time might be spent more productively if you would
> > work on some more useful projects.
>
> I hope that various change possibilities (from my selection) will become useful
> for more Linux users.
> How will the clarification evolve further?
>
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-10-30 9:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-24 10:20 [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations SF Markus Elfring
2017-09-24 10:22 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_c SF Markus Elfring
2017-09-24 10:35 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vo Joe Perches
2017-09-24 10:24 ` [PATCH 2/6] [media] omap_vout: Improve a size determination in two functions SF Markus Elfring
2017-09-24 10:26 ` [PATCH 3/6] [media] omap_vout: Adjust a null pointer check " SF Markus Elfring
2017-09-24 10:28 ` [PATCH 4/6] [media] omap_vout: Fix a possible null pointer dereference in omap_vout_open() SF Markus Elfring
2017-09-24 10:30 ` [PATCH 5/6] [media] omap_vout: Delete an unnecessary variable initialisation " SF Markus Elfring
2017-09-24 10:33 ` [PATCH 6/6] [media] omap_vout: Delete two unnecessary variable initialisations in omap_vout_probe() SF Markus Elfring
2017-10-30 8:36 ` [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations Hans Verkuil
2017-10-30 9:16 ` Adjustments for a lot of " SF Markus Elfring
2017-10-30 9:47 ` Julia Lawall [this message]
2017-10-30 9:57 ` Hans Verkuil
2017-10-30 10:40 ` SF Markus Elfring
2017-10-30 10:48 ` Hans Verkuil
2017-10-30 11:41 ` SF Markus Elfring
2017-11-26 19:06 ` SF Markus Elfring
2018-01-08 11:44 ` SF Markus Elfring
2018-02-02 9:55 ` SF Markus Elfring
2018-02-02 10:29 ` Hans Verkuil
2018-02-02 12:30 ` SF Markus Elfring
2018-02-10 8:39 ` SF Markus Elfring
2017-10-31 8:27 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710301745530.2160@hadrien \
--to=julia.lawall@lip6.fr \
--cc=elfring@users.sourceforge.net \
--cc=hvaibhav@ti.com \
--cc=hverkuil@xs4all.nl \
--cc=jack@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lstoakes@gmail.com \
--cc=mchehab@kernel.org \
--cc=mhocko@suse.com \
--cc=mkaricheri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox