From: Julia Lawall <julia.lawall@lip6.fr>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] security: keys: remove redundant assignment to key_ref
Date: Wed, 06 Dec 2017 14:53:03 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1712061551310.25998@hadrien> (raw)
In-Reply-To: <15713.1512571817@warthog.procyon.org.uk>
On Wed, 6 Dec 2017, David Howells wrote:
> James Morris <james.l.morris@oracle.com> wrote:
>
> > I think a general cleanup in that function to make all of these follow the
> > pattern:
> >
> > if (something) {
> > key_ref = ERR_PTR(-error);
> > goto error;
> > }
> >
> > rather than unconditionally setting the error first, would be better, but
> > this is a clear enough fix on its own.
>
> There's a preference in Linux to use:
>
> key_ref = ERR_PTR(-error);
> if (something)
> goto error;
>
> instead because it uses less vertical space. It might originally have been
> promulgated by Linus, but I don't remember. Though you do have a point - your
> way makes error handling less subject breakage from code rearrangement.
I have the impression that there are many examples of both approaches.
julia
>
> David
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-12-06 14:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 18:14 [PATCH] security: keys: remove redundant assignment to key_ref Colin King
2017-12-05 0:18 ` James Morris
2017-12-06 14:50 ` David Howells
2017-12-06 14:53 ` Julia Lawall [this message]
2017-12-07 0:49 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1712061551310.25998@hadrien \
--to=julia.lawall@lip6.fr \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox