From: Julia Lawall <julia.lawall@lip6.fr>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: Joe Perches <joe@perches.com>,
linux-pm@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: tps65090-charger: Delete an error message for a failed memory allocation in two functions
Date: Sat, 16 Dec 2017 20:36:51 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1712162135140.17082@hadrien> (raw)
In-Reply-To: <4beb0d2e-adf6-5eeb-43c7-7829d54c6656@users.sourceforge.net>
On Sat, 16 Dec 2017, SF Markus Elfring wrote:
> >> Omit an extra message for a memory allocation failure in these functions.
> >
> > Because???
> >
> > Fix your commit message.
> >
> > Say _WHY_ should this be applied.
>
> I am still waiting for possibilities to improve also the corresponding
> reference documentation somehow as you know it already.
If you require someone else to update the documentation to be able to
explain why the patch is useful, then it would seem that you do not know
why the patch is useful, and thus should not submit it.
julia
>
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-12-16 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-16 18:43 [PATCH] tps65090-charger: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-12-16 18:53 ` [PATCH] tps65090-charger: Delete an error message for a failed memory allocation in two function Joe Perches
2017-12-16 20:30 ` tps65090-charger: Delete an error message for a failed memory allocation in two functions SF Markus Elfring
2017-12-16 20:36 ` Julia Lawall [this message]
2017-12-16 20:47 ` SF Markus Elfring
2017-12-18 17:24 ` Sebastian Reichel
2017-12-18 17:32 ` SF Markus Elfring
2017-12-16 20:40 ` Joe Perches
2017-12-16 20:52 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1712162135140.17082@hadrien \
--to=julia.lawall@lip6.fr \
--cc=elfring@users.sourceforge.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox