From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Wed, 03 Jan 2018 08:06:01 +0000 Subject: Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions Message-Id: List-Id: References: <30191db0-4d99-0349-b66a-c7354ef90d50@users.sourceforge.net> <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> In-Reply-To: <0fea8f2f-f8fc-ce2e-3d33-44227de3637a@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tariq Toukan Cc: SF Markus Elfring , linux-rdma@vger.kernel.org, netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org On Wed, 3 Jan 2018, Tariq Toukan wrote: > > > On 01/01/2018 10:46 PM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 1 Jan 2018 21:42:27 +0100 > > > > Omit an extra message for a memory allocation failure in these functions. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring > > --- > > Is this an issue? Why? What is your motivation? > These are error messages, very informative, appear only upon errors, and in > control flow. Strings take up space. Since there is a backtrace on an out of memory problem, if the string does not provide any more information than the position of the call, then there is not much added value. I don't know what was the string in this case. If it provides some additional information, then it would be reasonable to keep it. julia > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >