Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings

Kalle Valo
2018-10-05T11:04:42Z

YueHaibing <yuehaibing@huawei.com> writes:

> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
>
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
>
> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci

Just out of curiosity, what kind of overhead are we talking about here?

--
Kalle Valo