From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Tue, 08 Jan 2019 16:44:25 +0000 Subject: Re: [PATCH 20/20] cw1200: drop useless LIST_HEAD Message-Id: List-Id: References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> <1545555435-24576-21-git-send-email-Julia.Lawall@lip6.fr> <87bm4rru12.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87bm4rru12.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kalle Valo Cc: Solomon Peachy , kernel-janitors@vger.kernel.org, "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org On Tue, 8 Jan 2019, Kalle Valo wrote: > Julia Lawall writes: > > > Drop LIST_HEAD where the variable it declares has never > > been used. > > > > The semantic patch that fixes this problem is as follows: > > (http://coccinelle.lip6.fr/) > > > > // > > @@ > > identifier x; > > @@ > > - LIST_HEAD(x); > > ... when != x > > // > > > > Fixes: a910e4a94f692 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") > > Signed-off-by: Julia Lawall > > > > --- > > Successfully 0-day tested on 151 configurations. > > I assume I can take this to wireless-drivers-next. If you are planning > to push this via some other tree please let me know. Please take it. Thanks. julia