From: Julia Lawall <julia.lawall@lip6.fr>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Fix for a small typo
Date: Tue, 12 Mar 2019 10:22:13 +0000 [thread overview]
Message-ID: <alpine.DEB.2.20.1903121120490.4097@hadrien> (raw)
In-Reply-To: <20190312095149.GA10972@machine1>
On Tue, 12 Mar 2019, Milan P. Gandhi wrote:
The patch should have a log message. For example, you could point out
where the type is so the reader doesn't have to search for it.
The subject line should also give a hint about what file is affected, so
that the right person will pay attention to it. You can see what subject
lines others have used on this file by:
git log --oneline drivers/scsi/qla2xxx/qla_bsg.c
julia
> Signed-off-by: Milan P. Gandhi <mgandhi@redhat.com>
> ---
> drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
> index 17d42658ad9a..f2b95f11a71c 100644
> --- a/drivers/scsi/qla2xxx/qla_bsg.c
> +++ b/drivers/scsi/qla2xxx/qla_bsg.c
> @@ -1354,7 +1354,7 @@ qla24xx_iidma(struct bsg_job *bsg_job)
>
> if (rval) {
> ql_log(ql_log_warn, vha, 0x704c,
> - "iIDMA cmd failed for %8phN -- "
> + "iiDMA cmd failed for %8phN -- "
> "%04x %x %04x %04x.\n", fcport->port_name,
> rval, fcport->fp_speed, mb[0], mb[1]);
> rval = (DID_ERROR << 16);
>
next prev parent reply other threads:[~2019-03-12 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 9:51 [PATCH] Fix for a small typo Milan P. Gandhi
2019-03-12 10:22 ` Julia Lawall [this message]
2019-03-12 11:16 ` Dan Carpenter
2019-03-12 11:32 ` Milan P. Gandhi
2019-03-12 11:36 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1903121120490.4097@hadrien \
--to=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox