From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Date: Thu, 28 Mar 2019 14:19:56 +0000 Subject: Re: [PATCH] coccinelle: put_device: reduce false positives Message-Id: MIME-Version: 1 Content-Type: multipart/mixed; boundary="8323329-504337998-1553782797=:2438" List-Id: References: <1553321671-27749-1-git-send-email-wen.yang99@zte.com.cn> <179bbdd1-3fcb-bba5-52b3-7f96973c7650@web.de> <20190326084512.GC32590@kadam> <20190326101103.GH32613@kadam> In-Reply-To: To: Masahiro Yamada Cc: Yi Wang , Michal Marek , kernel-janitors@vger.kernel.org, Nicolas Palix , Linux Kernel Mailing List , cocci@systeme.lip6.fr, Markus Elfring , Wen Yang , Dan Carpenter This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-504337998-1553782797=:2438 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 28 Mar 2019, Masahiro Yamada wrote: > On Tue, Mar 26, 2019 at 7:16 PM Julia Lawall wrote: > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > On Tue, Mar 26, 2019 at 10:38:43AM +0100, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 26 Mar 2019, Dan Carpenter wrote: > > > > > > > > > On Sat, Mar 23, 2019 at 09:06:54PM +0100, Julia Lawall wrote: > > > > > > > > > > > > > > > > > > On Sat, 23 Mar 2019, Markus Elfring wrote: > > > > > > > > > > > > > > Don't complain about a return when this function returns "&pdev->dev". > > > > > > > > > > > > > > Would this information qualify to add the tag “Fixes” to the commit message? > > > > > > > > > > > > Fixes tags relate to stable kernels, so that one can see which stable > > > > > > kernels a particular patch should be propagated to. There is no need to > > > > > > propagate patches on semantic patches to stable kernels. People who run > > > > > > stable kernels are interested in their behavior, not the bug finding > > > > > > rules that they contain. > > > > > > > > > > The Fixes tag is not just about stable... For example, we use them for > > > > > statistics to see how quickly bugs get fixed etc. > > > > > > > > OK. But still do we need fixes tags for bug finding rules? Perhaps if > > > > the previous version was really broken, and it would be really undesirable > > > > to use it. > > > > > > It's not worth resending a patch for that, but I probably would use the > > > fixes tag. It depends on your definition of "bug" really... I tell > > > people not to use Fixes for spelling mistakes and unused variables. But > > > I do use the Fixes tag for things like "an off by one in a sanity check > > > which doesn't affect run time because the index is always correct". > > > > OK, thanks. > > > > julia > > I added Fixes: tag, > and applied to linux-kbuild/fixes. Thanks! julia > > Thanks. > > -- > Best Regards > Masahiro Yamada > --8323329-504337998-1553782797=:2438--