From: Lukas Czerner <lczerner@redhat.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] turn BUG_ON for out of bound in
Date: Mon, 19 Jul 2010 11:09:40 +0000 [thread overview]
Message-ID: <alpine.LFD.2.00.1007191308150.3435@localhost> (raw)
In-Reply-To: <4C43083E.6020201@gmail.com>
On Mon, 19 Jul 2010, shenghui wrote:
> Sorry. Will you recommend to me one mail client?
> I have been suffering reformat by client these days.
> Thanks,
Mutt, or Alpine will be a very good choice.
This can be also useful:
Documentation/SubmittingPatches
Documentation/email-clients.txt
Cheers
-Lukas
>
>
> Signed-off-by: Wang Sheng-Hui <crosslonelyover@gmail.com>
> ---
> fs/mbcache.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/mbcache.c b/fs/mbcache.c
> index 5697d9e..5f96b82 100644
> --- a/fs/mbcache.c
> +++ b/fs/mbcache.c
> @@ -614,7 +614,7 @@ mb_cache_entry_find_first(struct mb_cache *cache, int
> index,
> struct list_head *l;
> struct mb_cache_entry *ce;
>
> - mb_assert(index < mb_cache_indexes(cache));
> + BUG_ON(!(index < mb_cache_indexes(cache)));
> spin_lock(&mb_cache_spinlock);
> l = cache->c_indexes_hash[index][bucket].next;
> ce = __mb_cache_entry_find(l, &cache->c_indexes_hash[index][bucket],
> @@ -652,7 +652,7 @@ mb_cache_entry_find_next(struct mb_cache_entry *prev, int
> index,
> struct list_head *l;
> struct mb_cache_entry *ce;
>
> - mb_assert(index < mb_cache_indexes(cache));
> + BUG_ON(!(index < mb_cache_indexes(cache)));
> spin_lock(&mb_cache_spinlock);
> l = prev->e_indexes[index].o_list.next;
> ce = __mb_cache_entry_find(l, &cache->c_indexes_hash[index][bucket],
>
prev parent reply other threads:[~2010-07-19 11:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-18 13:57 [PATCH 2/2] turn BUG_ON for out of bound in mb_cache_entry_find_first/mb_cache_entry_find_next Wang Sheng-Hui
2010-07-18 13:59 ` shenghui
2010-07-18 23:35 ` shenghui
2010-07-19 11:09 ` Lukas Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1007191308150.3435@localhost \
--to=lczerner@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).