[PATCH 2/2] drivers/staging/vt6656/iwctl.c: Remove unnecessary function

[PATCH 2/2] drivers/staging/vt6656/iwctl.c: Remove unnecessary function

[Marcos Paulo de Souza]

Removed the function iwctl_giwnwid, that was used once. Removed too a
switch/case statement that was ambiguous.

Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
---
 drivers/staging/vt6656/iwctl.c    |   11 -----------
 drivers/staging/vt6656/iwctl.h    |    5 -----
 drivers/staging/vt6656/main_usb.c |    9 +--------
 3 files changed, 1 insertions(+), 24 deletions(-)

diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
index 8c1ca49..a9110bf 100644
--- a/drivers/staging/vt6656/iwctl.c
+++ b/drivers/staging/vt6656/iwctl.c
@@ -127,17 +127,6 @@ int iwctl_giwname(struct net_device *dev,
 	return 0;
 }
 
-int iwctl_giwnwid(struct net_device *dev,
-             struct iw_request_info *info,
-			 struct iw_param *wrq,
-                   char *extra)
-{
- 	//wrq->value = 0x100;
-	//wrq->disabled = 0;
-	//wrq->fixed = 1;
-	//return 0;
-  return -EOPNOTSUPP;
-}
 /*
  * Wireless Handler : set scan
  */
diff --git a/drivers/staging/vt6656/iwctl.h b/drivers/staging/vt6656/iwctl.h
index cc48954..10a240e 100644
--- a/drivers/staging/vt6656/iwctl.h
+++ b/drivers/staging/vt6656/iwctl.h
@@ -77,11 +77,6 @@ int iwctl_giwname(struct net_device *dev,
 			 char *wrq,
 			 char *extra);
 
-int iwctl_giwnwid(struct net_device *dev,
-             struct iw_request_info *info,
-			 struct iw_param *wrq,
-                   char *extra) ;
-
 int iwctl_giwsens(struct net_device *dev,
 			 struct iw_request_info *info,
 			 struct iw_param *wrq,
diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 27521b6..6f9930a 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -1618,15 +1618,8 @@ static int  device_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) {
 		break;
 
 	case SIOCSIWNWID:
-        rc = -EOPNOTSUPP;
-		break;
-
 	case SIOCGIWNWID:     //0x8b03  support
-	#ifdef  WPA_SUPPLICANT_DRIVER_WEXT_SUPPORT
-          rc = iwctl_giwnwid(dev, NULL, &(wrq->u.nwid), NULL);
-	#else
-        rc = -EOPNOTSUPP;
-	#endif
+		rc = -EOPNOTSUPP;
 		break;
 
 		// Set frequency/channel
-- 
1.7.4.4

Re: [PATCH 2/2] drivers/staging/vt6656/iwctl.c: Remove unnecessary

[Marcos Paulo de Souza]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2533 bytes --]

Hi to all,

There is any suggestion about patch?

Thanks for your time.

* Uma vida sem desafios é uma vida sem razão *
* A life without challanges is a non reason life *

On Wed, 9 Nov 2011, Marcos Paulo de Souza wrote:

> Removed the function iwctl_giwnwid, that was used once. Removed too a
> switch/case statement that was ambiguous.
>
> Signed-off-by: Marcos Paulo de Souza <marcos.mage@gmail.com>
> ---
> drivers/staging/vt6656/iwctl.c    |   11 -----------
> drivers/staging/vt6656/iwctl.h    |    5 -----
> drivers/staging/vt6656/main_usb.c |    9 +--------
> 3 files changed, 1 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/staging/vt6656/iwctl.c b/drivers/staging/vt6656/iwctl.c
> index 8c1ca49..a9110bf 100644
> --- a/drivers/staging/vt6656/iwctl.c
> +++ b/drivers/staging/vt6656/iwctl.c
> @@ -127,17 +127,6 @@ int iwctl_giwname(struct net_device *dev,
> 	return 0;
> }
>
> -int iwctl_giwnwid(struct net_device *dev,
> -             struct iw_request_info *info,
> -			 struct iw_param *wrq,
> -                   char *extra)
> -{
> - 	//wrq->value = 0x100;
> -	//wrq->disabled = 0;
> -	//wrq->fixed = 1;
> -	//return 0;
> -  return -EOPNOTSUPP;
> -}
> /*
>  * Wireless Handler : set scan
>  */
> diff --git a/drivers/staging/vt6656/iwctl.h b/drivers/staging/vt6656/iwctl.h
> index cc48954..10a240e 100644
> --- a/drivers/staging/vt6656/iwctl.h
> +++ b/drivers/staging/vt6656/iwctl.h
> @@ -77,11 +77,6 @@ int iwctl_giwname(struct net_device *dev,
> 			 char *wrq,
> 			 char *extra);
>
> -int iwctl_giwnwid(struct net_device *dev,
> -             struct iw_request_info *info,
> -			 struct iw_param *wrq,
> -                   char *extra) ;
> -
> int iwctl_giwsens(struct net_device *dev,
> 			 struct iw_request_info *info,
> 			 struct iw_param *wrq,
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 27521b6..6f9930a 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -1618,15 +1618,8 @@ static int  device_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) {
> 		break;
>
> 	case SIOCSIWNWID:
> -        rc = -EOPNOTSUPP;
> -		break;
> -
> 	case SIOCGIWNWID:     //0x8b03  support
> -	#ifdef  WPA_SUPPLICANT_DRIVER_WEXT_SUPPORT
> -          rc = iwctl_giwnwid(dev, NULL, &(wrq->u.nwid), NULL);
> -	#else
> -        rc = -EOPNOTSUPP;
> -	#endif
> +		rc = -EOPNOTSUPP;
> 		break;
>
> 		// Set frequency/channel
> -- 
> 1.7.4.4
>
>

Re: [PATCH 2/2] drivers/staging/vt6656/iwctl.c: Remove unnecessary

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]

On Thu, Nov 17, 2011 at 06:41:50PM -0200, Marcos Paulo de Souza wrote:
> Hi to all,
> 
> There is any suggestion about patch?
> 

You didn't CC the driver devel list devel@driverdev.osuosl.org so the
patch was ignored probably.

But even there it often takes a couple weeks to hear back about a
patch and this one was only sent on the 17th so it's too early to be
asking about it.  There is still a long time left until the 3.3 merge
window opens up so it's not a rush.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]