From: James Morris <jmorris@namei.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-ima-devel@lists.sourceforge.net,
linux-ima-user@lists.sourceforge.net,
linux-security-module@vger.kernel.org,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/3] ima_fs: Move three error code assignments in ima_write_policy()
Date: Sun, 29 Jan 2017 23:43:31 +0000 [thread overview]
Message-ID: <alpine.LRH.2.20.1701301036590.27354@namei.org> (raw)
In-Reply-To: <1485520764.2596.89.camel@linux.vnet.ibm.com>
On Fri, 27 Jan 2017, Mimi Zohar wrote:
> On Wed, 2017-01-25 at 10:34 +0100, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Tue, 24 Jan 2017 22:47:07 +0100
> >
> > A local variable was set to an error code in three cases before a concrete
> > error situation was detected. Thus move the corresponding assignments into
> > if branches to indicate a software failure there.
> >
> > This issue was detected by using the Coccinelle software.
>
> This coding style was pretty common. I assume the compiler is smart
> enough to do the right thing. Is this a FYI, letting us know for the
> future the preferred coding style, or are we really upstreaming these
> sorts of coding style changes?
Nope, and I generally don't want cleanup patches from Markus going into
the security tree.
See also:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1254425.html
- James
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2017-01-29 23:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 9:30 [PATCH 0/3] ima_fs: Fine-tuning for ima_write_policy() SF Markus Elfring
2017-01-25 9:31 ` [PATCH 1/3] ima_fs: One check less in ima_write_policy() after error detection SF Markus Elfring
2017-01-27 12:38 ` Mimi Zohar
2017-01-25 9:33 ` [PATCH 2/3] ima_fs: Reorder input parameter validation in ima_write_policy() SF Markus Elfring
2017-01-25 9:34 ` [PATCH 3/3] ima_fs: Move three error code assignments " SF Markus Elfring
2017-01-27 12:39 ` Mimi Zohar
2017-01-29 23:43 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1701301036590.27354@namei.org \
--to=jmorris@namei.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=james.l.morris@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ima-devel@lists.sourceforge.net \
--cc=linux-ima-user@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox