From: Miroslav Benes <mbenes@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jessica Yu <jeyu@kernel.org>, Christoph Hellwig <hch@lst.de>,
Petr Mladek <pmladek@suse.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol()
Date: Wed, 10 Feb 2021 12:08:39 +0000 [thread overview]
Message-ID: <alpine.LSU.2.21.2102101307030.14803@pobox.suse.cz> (raw)
In-Reply-To: <YCO8AwE57IzaMamG@mwanda>
On Wed, 10 Feb 2021, Dan Carpenter wrote:
> Smatch complains that:
>
> kernel/module.c:4472 module_kallsyms_on_each_symbol()
> error: uninitialized symbol 'ret'.
>
> This warning looks like it could be correct if the &modules list is
> empty.
>
> Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
M
next prev parent reply other threads:[~2021-02-10 12:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 10:57 [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol() Dan Carpenter
2021-02-10 11:59 ` Christoph Hellwig
2021-02-10 12:08 ` Miroslav Benes [this message]
2021-02-10 16:17 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.21.2102101307030.14803@pobox.suse.cz \
--to=mbenes@suse.cz \
--cc=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=jeyu@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox