From: David Arcari <darcari@redhat.com>
To: Markus Elfring <Markus.Elfring@web.de>, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jerry Hoemann <jerry.hoemann@hpe.com>
Subject: Re: [PATCH] intel_th: core: fix null pointer dereference in intel_th_irq
Date: Mon, 29 Sep 2025 08:05:17 -0400 [thread overview]
Message-ID: <b1046b7f-817e-47b5-830d-71b1f9a9b4f0@redhat.com> (raw)
In-Reply-To: <1c96a836-122b-4f7d-a979-03a0bb6c3d4f@web.de>
Hi Markus,
On 9/27/25 10:54 AM, Markus Elfring wrote:
> …
>> +++ b/drivers/hwtracing/intel_th/core.c
>> @@ -715,7 +715,9 @@ intel_th_subdevice_alloc(struct intel_th *th,
>> int intel_th_output_enable(struct intel_th *th, unsigned int otype)
>> {
>> struct intel_th_device *thdev;
>> - int src = 0, dst = 0;
>> + int src = 0, dst = 0, ret = 0;
>> +
>> + disable_irq(th->irq);
> …
>> - return 0;
>> + enable_irq(th->irq);
>> + return ret;
>> }
> …
>
> How do you think about to increase the application of scope-based resource management?
> https://elixir.bootlin.com/linux/v6.17-rc7/source/include/linux/interrupt.h#L239-L240
At this point, I think that Alex is the best person to handle the
resolution of this issue.
Best,
-DA
>
> Regards,
> Markus
>
prev parent reply other threads:[~2025-09-29 12:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250825174554.925679-1-darcari@redhat.com>
2025-09-27 14:54 ` [PATCH] intel_th: core: fix null pointer dereference in intel_th_irq Markus Elfring
2025-09-29 12:05 ` David Arcari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1046b7f-817e-47b5-830d-71b1f9a9b4f0@redhat.com \
--to=darcari@redhat.com \
--cc=Markus.Elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=jerry.hoemann@hpe.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).