From: SF Markus Elfring <elfring@users.sourceforge.net>
To: "Stephan Müller" <smueller@chronox.de>, linux-crypto@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: crypto-testmgr: Use common error handling code in drbg_cavs_test()
Date: Sat, 21 Oct 2017 20:00:23 +0000 [thread overview]
Message-ID: <b270d9f1-a508-b5c1-8f53-260f4deb6fde@users.sourceforge.net> (raw)
In-Reply-To: <6795494.nv2bFMflat@tauon.chronox.de>
> Though, jumping back and forth like this with goto directives is something
> that looks a bit strange. At least to my taste, may I suggest to have gotos
> pointing only downwards and not up again? (Note, the same applies to the
> ansi_cprng patch set).
>
> What about something like following:
>
> ...
> memcmp
> goto free_rng;
Do you find an additional jump really acceptable at such a source code place?
> report_failure:
> <failure report>
>
> free_rng:
> <the deallocation code>
I am curious on how feedback will evolve also for the other design approach.
Regards,
Markus
next prev parent reply other threads:[~2017-10-21 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-21 17:52 [PATCH 0/2] crypto-testmgr: Fine-tuning for drbg_cavs_test() SF Markus Elfring
2017-10-21 17:53 ` [PATCH 1/2] crypto-testmgr: Use common error handling code in drbg_cavs_test() SF Markus Elfring
2017-10-21 19:07 ` Stephan Mueller
2017-10-21 20:00 ` SF Markus Elfring [this message]
2017-10-21 17:55 ` [PATCH 2/2] crypto-testmgr: Delete an unnecessary variable initialisation " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b270d9f1-a508-b5c1-8f53-260f4deb6fde@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox