From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 30 Apr 2017 14:20:33 +0000 Subject: MIPS: Lantiq: Completion of error handling around clkdev_add_clkout() Message-Id: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-mips@linux-mips.org, Arnd Bergmann , Felix Fietkau , Hauke Mehrtens , James Hogan , John Crispin , =?UTF-8?Q?Ralf_B=c3=a4chle?= Cc: LKML , kernel-janitors@vger.kernel.org, Pan Bian Hello, I have noticed by execution of another script for the semantic patch language (Coccinelle software) that the function “clkdev_add_clkout” does not contain null pointer checks after calls of the function “kzalloc”. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/mips/lantiq/xway/sysctrl.c?h=v4.10#n403 How do you think about to add corresponding checks and adjust the function return type there? Regards, Markus