From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe()
Date: Tue, 22 Aug 2017 15:03:00 +0000 [thread overview]
Message-ID: <b434f976-33a1-7ced-55b5-b55487f2fb14@users.sourceforge.net> (raw)
In-Reply-To: <s5h378j8xos.wl-tiwai@suse.de>
>> * I find it a bit safer when the error predicate is “return value != 0”.
>
> Can't agree.
How do you think about to reduce the probability that positive return values
will accidentally be interpreted as a successful function execution.
> And I have no interest to continue bike-shedding, sorry.
I do not like that you prefer to put this technical detail into such
a communication category.
> You can't convince me regarding this.
Would you still like to integrate the proposed refactoring with the use
of previous failure predicates then?
Regards,
Markus
next prev parent reply other threads:[~2017-08-22 15:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 12:10 [PATCH] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe() SF Markus Elfring
2017-08-22 12:16 ` Dan Carpenter
2017-08-22 12:28 ` Takashi Iwai
2017-08-22 12:47 ` SF Markus Elfring
2017-08-22 12:55 ` [alsa-devel] " Takashi Iwai
2017-08-22 13:15 ` SF Markus Elfring
2017-08-22 14:07 ` Takashi Iwai
2017-08-22 14:36 ` SF Markus Elfring
2017-08-22 14:49 ` Takashi Iwai
2017-08-22 15:03 ` SF Markus Elfring [this message]
2017-08-22 15:07 ` Takashi Iwai
2017-08-22 15:47 ` [PATCH v3] " SF Markus Elfring
2017-08-22 15:59 ` Takashi Iwai
2017-08-22 14:00 ` [PATCH v2] " SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b434f976-33a1-7ced-55b5-b55487f2fb14@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox