From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Rob Clark <robdclark@gmail.com>,
Chandan Uddaraju <chandanu@codeaurora.org>
Cc: Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
Abhinav Kumar <abhinavk@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Archit Taneja <architt@codeaurora.org>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/msm/dsi: Fix an error code in msm_dsi_modeset_init()
Date: Sat, 2 Oct 2021 01:45:52 +0300 [thread overview]
Message-ID: <b5016410-4e26-cbc5-0794-db9482aa3a71@linaro.org> (raw)
In-Reply-To: <20211001123308.GF2283@kili>
On 01/10/2021 15:33, Dan Carpenter wrote:
> Return an error code if msm_dsi_manager_validate_current_config().
> Don't return success.
>
> Fixes: 8b03ad30e314 ("drm/msm/dsi: Use one connector for dual DSI mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/dsi/dsi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi.c b/drivers/gpu/drm/msm/dsi/dsi.c
> index 614dc7f26f2c..75ae3008b68f 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi.c
> @@ -215,8 +215,10 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev,
> goto fail;
> }
>
> - if (!msm_dsi_manager_validate_current_config(msm_dsi->id))
> + if (!msm_dsi_manager_validate_current_config(msm_dsi->id)) {
> + ret = -EINVAL;
> goto fail;
> + }
>
> msm_dsi->encoder = encoder;
>
>
--
With best wishes
Dmitry
prev parent reply other threads:[~2021-10-01 22:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 12:33 [PATCH 1/3] drm/msm/dsi: Fix an error code in msm_dsi_modeset_init() Dan Carpenter
2021-10-01 12:34 ` [PATCH 2/3] drm/msm/dsi: fix off by one in dsi_bus_clk_enable error handling Dan Carpenter
2021-10-01 22:47 ` Dmitry Baryshkov
2021-10-01 12:36 ` [PATCH 3/3] drm/msm/dsi: fix signedness bug in msm_dsi_host_cmd_rx() Dan Carpenter
2021-10-01 22:59 ` Dmitry Baryshkov
2021-10-04 6:18 ` Dan Carpenter
2021-10-04 6:45 ` Dan Carpenter
2021-10-01 22:45 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5016410-4e26-cbc5-0794-db9482aa3a71@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=chandanu@codeaurora.org \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox