From mboxrd@z Thu Jan 1 00:00:00 1970 From: "santosh.shilimkar@oracle.com" Date: Mon, 12 Mar 2018 06:54:56 +0000 Subject: Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user st Message-Id: List-Id: References: <20180311170340.27696-1-colin.king@canonical.com> In-Reply-To: <20180311170340.27696-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King , "David S . Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On 3/11/18 10:03 AM, Colin King wrote: > From: Colin Ian King > > Functions rds_info_from_znotifier and rds_message_zcopy_from_user are > local to the source and do not need to be in global scope, so make them > static. > > Cleans up sparse warnins: > net/rds/message.c:70:27: warning: symbol 'rds_info_from_znotifier' was > not declared. Should it be static? > net/rds/message.c:358:5: warning: symbol 'rds_message_zcopy_from_user' > was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > net/rds/message.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Acked-by: Santosh Shilimkar